Summary

Consolidate functionality for building column definition schemas.

Review Request #12224 — Created April 5, 2022 and submitted April 8, 2022, 8:39 p.m.

Information

Owner

chipx86

Repository

Django Evolution

Branch

release-2.x

Bugs

Depends On

Reviewers

Groups

django-evolution

People

Description

This introduces BaseEvolutionOperations.build_column_schema(), which
will compute pieces of SQL needed in order to create or re-create a
column.

This sort of operation has been implemented in a few different spots in
the codebase, in a few different ways. This consolidates all these,
simplifying the code paths, easing maintainability, and setting things
up for an upcoming change for field type changes.

There is one change to the generation that impacts the SQLite3 tests,
but not any actual operation. The old logic would generate a UNIQUE
for a PRIMARY KEY, which wasn't at all necessary. The new logic avoids
that.

Testing Done

Unit tests pass for all versions of Django and all databases.

Commits

Summary	ID
Consolidate functionality for building column definition schemas. This introduces `BaseEvolutionOperations.build_column_schema()`, which will compute pieces of SQL needed in order to create or re-create a column. This sort of operation has been implemented in a few different spots in the codebase, in a few different ways. This consolidates all these, simplifying the code paths, easing maintainability, and setting things up for an upcoming change for field type changes. There is one change to the generation that impacts the SQLite3 tests, but not any actual operation. The old logic would generate a `UNIQUE` for a `PRIMARY KEY`, which wasn't at all necessary. The new logic avoids that.	3143193ab76c3b4e07badfc95320c1dcf18252ea

Summary

Consolidate functionality for building column definition schemas.

This introduces `BaseEvolutionOperations.build_column_schema()`, which will compute pieces of SQL needed in order to create or re-create a column. This sort of operation has been implemented in a few different spots in the codebase, in a few different ways. This consolidates all these, simplifying the code paths, easing maintainability, and setting things up for an upcoming change for field type changes. There is one change to the generation that impacts the SQLite3 tests, but not any actual operation. The old logic would generate a `UNIQUE` for a `PRIMARY KEY`, which wasn't at all necessary. The new logic avoids that.

3143193ab76c3b4e07badfc95320c1dcf18252ea

Issues

Description	From	Last Updated
F841 local variable 'sql_result' is assigned to but never used	reviewbot	April 5, 2022, 4:31 p.m.
F841 local variable 'table_name' is assigned to but never used	reviewbot	April 5, 2022, 4:31 p.m.
F821 undefined name 'new_field'	reviewbot	April 5, 2022, 4:31 p.m.
F821 undefined name 'new_field'	reviewbot	April 5, 2022, 4:31 p.m.
F841 local variable 'remote_field' is assigned to but never used	reviewbot	April 5, 2022, 4:31 p.m.

flake8 failed.

JSHint passed.

flake8

django_evolution/db/common.py (Diff revision 1)

Show all issues

F841 local variable 'sql_result' is assigned to but never used

django_evolution/db/common.py (Diff revision 1)

Show all issues

F841 local variable 'table_name' is assigned to but never used

django_evolution/db/common.py (Diff revision 1)
Show all issues
```
F821 undefined name 'new_field'
```
django_evolution/db/common.py (Diff revision 1)
Show all issues
```
F821 undefined name 'new_field'
```

django_evolution/db/common.py (Diff revision 1)

Show all issues

F841 local variable 'remote_field' is assigned to but never used

Change Summary:


Removed some unused variables.
Fixed a bad variable reference.

Commits:

	Summary	ID
	Consolidate functionality for building column definition schemas. This introduces `BaseEvolutionOperations.build_column_schema()`, which will compute pieces of SQL needed in order to create or re-create a column. This sort of operation has been implemented in a few different spots in the codebase, in a few different ways. This consolidates all these, simplifying the code paths, easing maintainability, and setting things up for an upcoming change for field type changes. There is one change to the generation that impacts the SQLite3 tests, but not any actual operation. The old logic would generate a `UNIQUE` for a `PRIMARY KEY`, which wasn't at all necessary. The new logic avoids that.	1db924d4acf44f0f580fd36d311475e73b647ce7
	Consolidate functionality for building column definition schemas. This introduces `BaseEvolutionOperations.build_column_schema()`, which will compute pieces of SQL needed in order to create or re-create a column. This sort of operation has been implemented in a few different spots in the codebase, in a few different ways. This consolidates all these, simplifying the code paths, easing maintainability, and setting things up for an upcoming change for field type changes. There is one change to the generation that impacts the SQLite3 tests, but not any actual operation. The old logic would generate a `UNIQUE` for a `PRIMARY KEY`, which wasn't at all necessary. The new logic avoids that.	3143193ab76c3b4e07badfc95320c1dcf18252ea

Diff:

Revision 2 (+684 -528)

Show changes

	django_evolution/db/common.py
	django_evolution/db/mysql.py
	django_evolution/db/sqlite3.py
	django_evolution/tests/db/mysql.py
	django_evolution/tests/db/sqlite3.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.x (f14c85c)