Added automated_service_info field when closing or editing review requests automatically

Review Request #12223 — Created March 31, 2022 and updated — Latest diff uploaded

Information

Review Board
master

Reviewers

Added automated_service_info field alongside automated flag to
provide details on the service that updated/closed the review
request automatically.

  • Added automated_service_info field to hook_utils,
    ReviewRequestResourceAPI Update(), and
    review_request.close() to store the value in
    ChangeDescription model.

  • Added automated_service_info field to
    ReviewRequestResourceDraftAPI Update(), Create(),
    review_request.publish(), draft.publish() to store the value
    in ChangeDescription model.

  • Added automated_service_info field to closed/published
    signals and email-related methods.

Added unit tests to test_email_sending.py
Added unit tests to test_review_request.py
Added unit tests to test_review_request_draft.py
Added unit tests to webapi/tests/test_review_request.py
Added unit tests to webapi/tests/test_review_request_draft.py
Added assertion to test_github.py, test_rbgateway.py,
test_bitbucket.py

All tests passed.

Diff Revision 2 (Latest)

orig
1
2

Commits

First Last Summary ID Author
Resolved rebase conflict
1a7a9f92fb96a621c4fd3b261557f9fd77dba659 sng06
Resolved rebase conflicts in unit tests
89a4fd6603ab502d442b3e41f2c7fbc71bd36151 sng06
Deleted automated_service_info from signal handlers and prepare_review_reques...
2c2bb0e84ffa70cfa56a6d9de47f96e6f1aed39a sng06
Fixed docstring typo for webapi/tests/test_review_request unit tests
65e1fdbe179ddf4febd361e142db10529296ee43 sng06
reviewboard/hostingsvcs/hook_utils.py
reviewboard/hostingsvcs/tests/test_bitbucket.py
reviewboard/hostingsvcs/tests/test_github.py
reviewboard/hostingsvcs/tests/test_rbgateway.py
reviewboard/notifications/email/message.py
reviewboard/notifications/tests/test_email_sending.py
reviewboard/reviews/signals.py
reviewboard/reviews/models/review_request.py
reviewboard/reviews/models/review_request_draft.py
reviewboard/reviews/tests/test_review_request.py
reviewboard/reviews/tests/test_review_request_draft.py
reviewboard/webapi/resources/review_request.py
reviewboard/webapi/resources/review_request_draft.py
reviewboard/webapi/tests/test_review_request.py
reviewboard/webapi/tests/test_review_request_draft.py
Loading...