Summary

Move all Django Evolution settings into a DJANGO_EVOLUTION dictionary.

Review Request #12218 — Created March 30, 2022 and submitted April 5, 2022, 4:28 p.m.

Information

Owner

chipx86

Repository

Django Evolution

Branch

release-2.x

Bugs

Depends On

Reviewers

Groups

django-evolution

People

Description

In an effort to better namespace Django Evolution settings and keep them

manageable, this change introduces a new settings.DJANGO_EVOLUTION

dictionary. Currently, this supports CUSTOM_EVOLUTIONS and ENABLED

keys, but will later include a CUSTOM_MIGRATIONS setting.
The old settings.DJANGO_EVOLUTION_ENABLED and settings.CUSTOM_EVOLUTIONS

are still supported, but will emit a deprecation warning.
All settings are now accessed through a new

django_evolution.conf.django_evolution_settings object, which is an

instance of DjangoEvolutionSettings. This manages loading settings (both

modern and legacy), defaults, and responding to Django's settings_changed

signal.

Testing Done

Unit tests pass on all versions of Django and Python.

Manually tested the values by tweaking Django settings and running management
commands.

Commits

Summary	ID
Move all Django Evolution settings into a DJANGO_EVOLUTION dictionary. In an effort to better namespace Django Evolution settings and keep them manageable, this change introduces a new `settings.DJANGO_EVOLUTION` dictionary. Currently, this supports `CUSTOM_EVOLUTIONS` and `ENABLED` keys, but will later include a `CUSTOM_MIGRATIONS` setting. The old `settings.DJANGO_EVOLUTION_ENABLED` and `settings.CUSTOM_EVOLUTIONS` are still supported, but will emit a deprecation warning. All settings are now accessed through a new `django_evolution.conf.settings` object, which is an instance of `DjangoEvolutionSettings`. This manages loading settings (both modern and legacy), defaults, and responding to Django's `settings_changed` signal.	2d1d887fb6a3b742b5b75a2c3db5ade35448ecb5

Summary

Move all Django Evolution settings into a DJANGO_EVOLUTION dictionary.

In an effort to better namespace Django Evolution settings and keep them manageable, this change introduces a new `settings.DJANGO_EVOLUTION` dictionary. Currently, this supports `CUSTOM_EVOLUTIONS` and `ENABLED` keys, but will later include a `CUSTOM_MIGRATIONS` setting. The old `settings.DJANGO_EVOLUTION_ENABLED` and `settings.CUSTOM_EVOLUTIONS` are still supported, but will emit a deprecation warning. All settings are now accessed through a new `django_evolution.conf.settings` object, which is an instance of `DjangoEvolutionSettings`. This manages loading settings (both modern and legacy), defaults, and responding to Django's `settings_changed` signal.

2d1d887fb6a3b742b5b75a2c3db5ade35448ecb5

Issues

Description	From	Last Updated
F401 'django.conf.settings' imported but unused	reviewbot	March 30, 2022, 4:20 p.m.
F401 'django_evolution.conf.setting_changed' imported but unused	reviewbot	March 30, 2022, 4:20 p.m.

flake8 failed.

JSHint passed.

flake8

django_evolution/tests/test_conf.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'django.conf.settings' imported but unused
```
django_evolution/tests/test_conf.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'django_evolution.conf.setting_changed' imported but unused
```

Change Summary:

Removed unused imports.

Commits:

	Summary	ID
	Move all Django Evolution settings into a DJANGO_EVOLUTION dictionary. In an effort to better namespace Django Evolution settings and keep them manageable, this change introduces a new `settings.DJANGO_EVOLUTION` dictionary. Currently, this supports `CUSTOM_EVOLUTIONS` and `ENABLED` keys, but will later include a `CUSTOM_MIGRATIONS` setting. The old `settings.DJANGO_EVOLUTION_ENABLED` and `settings.CUSTOM_EVOLUTIONS` are still supported, but will emit a deprecation warning. All settings are now accessed through a new `django_evolution.conf.settings` object, which is an instance of `DjangoEvolutionSettings`. This manages loading settings (both modern and legacy), defaults, and responding to Django's `settings_changed` signal.	bc7d70a930ca81e4ad711a447e931214294ea9b8
	Move all Django Evolution settings into a DJANGO_EVOLUTION dictionary. In an effort to better namespace Django Evolution settings and keep them manageable, this change introduces a new `settings.DJANGO_EVOLUTION` dictionary. Currently, this supports `CUSTOM_EVOLUTIONS` and `ENABLED` keys, but will later include a `CUSTOM_MIGRATIONS` setting. The old `settings.DJANGO_EVOLUTION_ENABLED` and `settings.CUSTOM_EVOLUTIONS` are still supported, but will emit a deprecation warning. All settings are now accessed through a new `django_evolution.conf.settings` object, which is an instance of `DjangoEvolutionSettings`. This manages loading settings (both modern and legacy), defaults, and responding to Django's `settings_changed` signal.	2d1d887fb6a3b742b5b75a2c3db5ade35448ecb5

Diff:

Revision 2 (+818 -16)

Show changes

	django_evolution/conf.py
	django_evolution/management/__init__.py
	django_evolution/management/commands/evolve.py
	django_evolution/management/commands/migrate.py
	django_evolution/management/commands/syncdb.py
	django_evolution/tests/test_conf.py
	django_evolution/tests/test_evolution_utils.py
	django_evolution/utils/evolutions.py
	1 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.x (387831a)