Use registry get_defaults() to return built-in authentication backends.

Review Request #12213 — Created March 26, 2022 and submitted

Information

Review Board
release-5.0.x

Reviewers

Entry points are fantastic, and they're a great way for us to allow
third parties to integrate their own plugins with Review Board.
Unfortunately, if there's a VersionConflict present in the install, no
entry points will load, even if things will otherwise work. This means
that no alternative authentication backends will load, which is extra
bad because this may make it particulary difficult for administrators to
log in to even start debugging the issue (such as looking at the log
viewer in the admin).

This change moves the built-in authentication backends into the
registry's get_defaults() method, rather than using entry points. Any
third-party services will still be loaded from entry points afterwards.

Started with a fresh database and virtualenv. Saw that built-in
authentication backends were available in the authentication page of the
admin site.

Summary ID
Use registry get_defaults() to return built-in authentication backends.
Entry points are fantastic, and they're a great way for us to allow third parties to integrate their own plugins with Review Board. Unfortunately, if there's a `VersionConflict` present in the install, no entry points will load, even if things will otherwise work. This means that no alternative authentication backends will load, which is extra bad because this may make it particulary difficult for administrators to log in to even start debugging the issue (such as looking at the log viewer in the admin). This change moves the built-in authentication backends into the registry's `get_defaults()` method, rather than using entry points. Any third-party services will still be loaded from entry points afterwards. Testing Done: Started with a fresh database and virtualenv. Saw that built-in authentication backends were available in the authentication page of the admin site.
ce31f1709ed30bcfb94db9eec743939d8b93ba6d
Description From Last Updated

Can we put these in alphabetical order? (Not sure why they weren't before).

chipx86chipx86
chipx86
  1. 
      
  2. reviewboard/accounts/backends/registry.py (Diff revision 1)
     
     
     
     
     
     
    Show all issues

    Can we put these in alphabetical order? (Not sure why they weren't before).

  3. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-5.0.x (b37991d)