Add signature support for all current Index attributes.

Review Request #12211 — Created March 25, 2022 and submitted

Information

Django Evolution
release-2.x

Reviewers

Index signatures can now store condition, db_tablespace,
expressions, include, and opclasses.

Many of these are stored in attrs for future management of attributes,
and these map to keyword arguments on Index. expressions maps to
positional arguments, and are stored separately. Existing attributes
(name and fields) remain at the top-level of the signature
dictionary.

Unit tests pass on all supported versions of Python and Django.

Summary ID
Add signature support for all current Index attributes.
Index signatures can now store `condition`, `db_tablespace`, `expressions`, `include`, and `opclasses`. Many of these are stored in `attrs` for future management of attributes, and these map to keyword arguments on `Index`. `expressions` maps to positional arguments, and are stored separately. Existing attributes (`name` and `fields`) remain at the top-level of the signature dictionary.
d7e65cc0da0ad4ac0a723bfcf39714922792504b
Description From Last Updated

F401 'copy.deepcopy' imported but unused

reviewbotreviewbot

F401 'django_evolution.support.supports_q_comparison' imported but unused

reviewbotreviewbot

F401 'django_evolution.support.supports_f_comparison' imported but unused

reviewbotreviewbot

F401 'django_evolution.tests.decorators.requires_attr' imported but unused

reviewbotreviewbot

F811 redefinition of unused 'test_ne_with_different_conditions' from line 2752

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.x (113884f)
Loading...