Summary:

Add signature support for all current Index attributes.

Review Request #12211 — Created March 25, 2022 and submitted April 5, 2022, 4:23 p.m.

Information
Owner:	chipx86
Repository:	Django Evolution
Branch:	release-2.x
Bugs:
Depends On:
Reviewers
Groups:	django-evolution
People:

Description

Index signatures can now store condition, db_tablespace,
expressions, include, and opclasses.

Many of these are stored in attrs for future management of attributes,
and these map to keyword arguments on Index. expressions maps to
positional arguments, and are stored separately. Existing attributes
(name and fields) remain at the top-level of the signature
dictionary.

Testing Done

Unit tests pass on all supported versions of Python and Django.

Commits

Summary
	Add signature support for all current Index attributes.

Screenshots

Issues

Description	From	Last Updated
F401 'copy.deepcopy' imported but unused	reviewbot	March 25, 2022, 6:21 p.m.
F401 'django_evolution.support.supports_q_comparison' imported but unused	reviewbot	March 25, 2022, 6:21 p.m.
F401 'django_evolution.support.supports_f_comparison' imported but unused	reviewbot	March 25, 2022, 6:21 p.m.
F401 'django_evolution.tests.decorators.requires_attr' imported but unused	reviewbot	March 25, 2022, 6:21 p.m.
F811 redefinition of unused 'test_ne_with_different_conditions' from line 2752	reviewbot	March 25, 2022, 6:21 p.m.

flake8 failed.

JSHint passed.

flake8

django_evolution/tests/test_signature.py (Diff revision 1)
Show all issues
```
F401 'copy.deepcopy' imported but unused
```

django_evolution/tests/test_signature.py (Diff revision 1)

Show all issues

F401 'django_evolution.support.supports_q_comparison' imported but unused

django_evolution/tests/test_signature.py (Diff revision 1)

Show all issues

F401 'django_evolution.support.supports_f_comparison' imported but unused

django_evolution/tests/test_signature.py (Diff revision 1)

Show all issues

F401 'django_evolution.tests.decorators.requires_attr' imported but unused

django_evolution/tests/test_signature.py (Diff revision 1)

Show all issues

F811 redefinition of unused 'test_ne_with_different_conditions' from line 2752

Change Summary:


Removed unused imports.
Fixed a duplicate test name and re-ran the suites.

Commits:

	Summary
-		Add signature support for all current Index attributes.
+		Add signature support for all current Index attributes.

Diff:

Revision 2 (+1224 -80)

Show changes

	django_evolution/signature.py
	django_evolution/support.py
	django_evolution/tests/decorators.py
	django_evolution/tests/test_signature.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.x (113884f)