Summary

Update remaining rb-extension-pack extensions for Review Board 5.0.

Review Request #12208 — Created March 24, 2022 and submitted May 31, 2022, 11:11 p.m.

Information

Owner

david

Repository

rb-extension-pack

Branch

master

Bugs

Depends On

Reviewers

Groups

rb-extension-pack

People

Description

Some text type stuff and defining JS type classes in the XML review UI
Mark the ships as raw strings, and fix up the signature for the signal
handler for the ASCII art extension.

Testing Done

Installed and activated each extension.

Commits

Summary	ID
Update remaining rb-extension-pack extensions for Review Board 5.0. This change makes some quite mechanical changes for the remaining extension pack items: message of the day, notes field, comment severity, stopwatch, XML review UI, review together, and the ship-it ASCII art extension. For the most part this is just trivial updates to imports and dependencies, but there are a couple tiny actual code changes: * Some text type stuff and defining JS type classes in the XML review UI * Mark the ships as raw strings, and fix up the signature for the signal handler for the ASCII art extension. Testing Done: Installed and activated each extension.	cffb7fa1fc93985cc98ae3bd56813e21eaff5b2a

Summary

Update remaining rb-extension-pack extensions for Review Board 5.0.

This change makes some quite mechanical changes for the remaining extension pack items: message of the day, notes field, comment severity, stopwatch, XML review UI, review together, and the ship-it ASCII art extension. For the most part this is just trivial updates to imports and dependencies, but there are a couple tiny actual code changes: * Some text type stuff and defining JS type classes in the XML review UI * Mark the ships as raw strings, and fix up the signature for the signal handler for the ASCII art extension. Testing Done: Installed and activated each extension.

cffb7fa1fc93985cc98ae3bd56813e21eaff5b2a

Issues

Description	From	Last Updated
Given breaking changes, we'll want to bump all the major versions (and reset the rest, including to "alpha" and release …	chipx86	May 30, 2022, 11:43 a.m.

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

Given breaking changes, we'll want to bump all the major versions (and reset the rest, including to "alpha" and release "False", if needed).

Commits:

	Summary	ID
	Update remaining rb-extension-pack extensions for Review Board 5.0. This change makes some quite mechanical changes for the remaining extension pack items: message of the day, notes field, comment severity, stopwatch, XML review UI, review together, and the ship-it ASCII art extension. For the most part this is just trivial updates to imports and dependencies, but there are a couple tiny actual code changes: * Some text type stuff and defining JS type classes in the XML review UI * Mark the ships as raw strings, and fix up the signature for the signal handler for the ASCII art extension. Testing Done: Installed and activated each extension.	4b503d2dacf0061381ae4ad3b3b90cbbef28490c
	Update remaining rb-extension-pack extensions for Review Board 5.0. This change makes some quite mechanical changes for the remaining extension pack items: message of the day, notes field, comment severity, stopwatch, XML review UI, review together, and the ship-it ASCII art extension. For the most part this is just trivial updates to imports and dependencies, but there are a couple tiny actual code changes: * Some text type stuff and defining JS type classes in the XML review UI * Mark the ships as raw strings, and fix up the signature for the signal handler for the ASCII art extension. Testing Done: Installed and activated each extension.	cffb7fa1fc93985cc98ae3bd56813e21eaff5b2a

Diff:

Revision 2 (+484 -296)

Show changes

	rbmotd/setup.py
	rbmotd/rbmotd/__init__.py
	rbmotd/rbmotd/admin_urls.py
	rbmotd/rbmotd/extension.py
	rbmotd/rbmotd/forms.py
	rbnotefield/setup.py
	rbnotefield/rbnotefield/__init__.py
	rbnotefield/rbnotefield/extension.py
	21 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (3db184e)