• 
      

    Update remaining rb-extension-pack extensions for Review Board 5.0.

    Review Request #12208 — Created March 24, 2022 and submitted

    Information

    rb-extension-pack
    master

    Reviewers

    This change makes some quite mechanical changes for the remaining
    extension pack items: message of the day, notes field, comment severity,
    stopwatch, XML review UI, review together, and the ship-it ASCII art
    extension. For the most part this is just trivial updates to imports and
    dependencies, but there are a couple tiny actual code changes:

    • Some text type stuff and defining JS type classes in the XML review UI
    • Mark the ships as raw strings, and fix up the signature for the signal
      handler for the ASCII art extension.

    Installed and activated each extension.

    Summary ID
    Update remaining rb-extension-pack extensions for Review Board 5.0.
    This change makes some quite mechanical changes for the remaining extension pack items: message of the day, notes field, comment severity, stopwatch, XML review UI, review together, and the ship-it ASCII art extension. For the most part this is just trivial updates to imports and dependencies, but there are a couple tiny actual code changes: * Some text type stuff and defining JS type classes in the XML review UI * Mark the ships as raw strings, and fix up the signature for the signal handler for the ASCII art extension. Testing Done: Installed and activated each extension.
    cffb7fa1fc93985cc98ae3bd56813e21eaff5b2a
    Description From Last Updated

    Given breaking changes, we'll want to bump all the major versions (and reset the rest, including to "alpha" and release …

    chipx86chipx86
    chipx86
    1. 
        
    2. Show all issues

      Given breaking changes, we'll want to bump all the major versions (and reset the rest, including to "alpha" and release "False", if needed).

    3. 
        
    david
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (3db184e)