Fix and update the rbchecklist extension for Review Board 5.0.

Review Request #12202 — Created March 24, 2022 and submitted

david
rb-extension-pack
master
rb-extension-pack

This change updates the rbchecklist extension for Review Board 5.0.x and
Django 3.2. This extension was also broken in a few ways, and I've fixed
up the things that were causing it to break (some problems with error
handling on the JS side, and a missing HTML element that was causing the
settings page to show poorly).

I'd really like to start over on this extension--what we have is both
under-featured and over-complex, and the visual design is highly
lacking. For now, this change gets things limping along again.

Installed and activated the extension. Was able to use the features
successfully.

Summary
Fix and update the rbchecklist extension for Review Board 5.0.
Description From Last Updated

Col: 72 Missing semicolon.

reviewbotreviewbot

This is a breaking change, so we need to bump major.

chipx86chipx86

do we use docstrings in __init__.py files? i've seen some places in the codebase have them and some don't. if …

maubinmaubin

add docstring

maubinmaubin
Checks run (1 failed, 1 succeeded)
flake8 passed.
JSHint failed.

JSHint

david
chipx86
  1. 
      
  2. rbchecklist/rbchecklist/__init__.py (Diff revision 2)
     
     

    This is a breaking change, so we need to bump major.

  3. 
      
david
maubin
  1. 
      
  2. do we use docstrings in __init__.py files? i've seen some places in the codebase have them and some don't. if so you could add one here

    1. We didn't before, but we have been over time. My eventual goal is to get it so we can run pydocstyle (or some customized/pluginized version of it), so good catch.

  3. 
      
david
maubin
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (f51ce8a)
Loading...