Summary

Fix and update the rbchecklist extension for Review Board 5.0.

Review Request #12202 — Created March 24, 2022 and submitted June 3, 2022, 12:33 p.m.

Information

Owner

david

Repository

rb-extension-pack

Branch

master

Bugs

Depends On

Reviewers

Groups

rb-extension-pack

People

Description

I'd really like to start over on this extension--what we have is both
under-featured and over-complex, and the visual design is highly
lacking. For now, this change gets things limping along again.

Testing Done

Installed and activated the extension. Was able to use the features
successfully.

Commits

Summary	ID
Fix and update the rbchecklist extension for Review Board 5.0. This change updates the rbchecklist extension for Review Board 5.0.x and Django 3.2. This extension was also broken in a few ways, and I've fixed up the things that were causing it to break (some problems with error handling on the JS side, and a missing HTML element that was causing the settings page to show poorly). I'd really like to start over on this extension--what we have is both under-featured and over-complex, and the visual design is highly lacking. For now, this change gets things limping along again. Testing Done: Installed and activated the extension. Was able to use the features successfully.	035d766d122870256aa06c87ac30ccf733aa731c

Summary

Fix and update the rbchecklist extension for Review Board 5.0.

This change updates the rbchecklist extension for Review Board 5.0.x and Django 3.2. This extension was also broken in a few ways, and I've fixed up the things that were causing it to break (some problems with error handling on the JS side, and a missing HTML element that was causing the settings page to show poorly). I'd really like to start over on this extension--what we have is both under-featured and over-complex, and the visual design is highly lacking. For now, this change gets things limping along again. Testing Done: Installed and activated the extension. Was able to use the features successfully.

035d766d122870256aa06c87ac30ccf733aa731c

Issues

Description	From	Last Updated
Col: 72 Missing semicolon.	reviewbot	March 24, 2022, 9:33 a.m.
This is a breaking change, so we need to bump major.	chipx86	May 30, 2022, 11:40 a.m.
do we use docstrings in __init__.py files? i've seen some places in the codebase have them and some don't. if …	maubin	May 31, 2022, 11:13 p.m.
add docstring	maubin	May 31, 2022, 11:13 p.m.

flake8 passed.

JSHint failed.

JSHint

rbchecklist/rbchecklist/static/js/models/checklistTemplateModel.es6.js (Diff revision 1)
Show all issues
```
Col: 72
 Missing semicolon.
```

Commits:

	Summary	ID
	Fix and update the rbchecklist extension for Review Board 5.0. This change updates the rbchecklist extension for Review Board 5.0.x and Django 3.2. This extension was also broken in a few ways, and I've fixed up the things that were causing it to break (some problems with error handling on the JS side, and a missing HTML element that was causing the settings page to show poorly). I'd really like to start over on this extension--what we have is both under-featured and over-complex, and the visual design is highly lacking. For now, this change gets things limping along again. Testing Done: Installed and activated the extension. Was able to use the features successfully.	aaa53b402756a4064a74283e61b77c6ed1419c96
	Fix and update the rbchecklist extension for Review Board 5.0. This change updates the rbchecklist extension for Review Board 5.0.x and Django 3.2. This extension was also broken in a few ways, and I've fixed up the things that were causing it to break (some problems with error handling on the JS side, and a missing HTML element that was causing the settings page to show poorly). I'd really like to start over on this extension--what we have is both under-featured and over-complex, and the visual design is highly lacking. For now, this change gets things limping along again. Testing Done: Installed and activated the extension. Was able to use the features successfully.	7897c3fbdfc8aa01b1a44ce307fb87c36f2d13ec

Diff:

Revision 2 (+332 -196)

Show changes

	rbchecklist/setup.py
	rbchecklist/rbchecklist/__init__.py
	rbchecklist/rbchecklist/extension.py
	rbchecklist/rbchecklist/models.py
	rbchecklist/rbchecklist/resources/__init__.py
	rbchecklist/rbchecklist/resources/checklist_item.py
	rbchecklist/rbchecklist/resources/checklist_resource.py
	rbchecklist/rbchecklist/static/js/models/checklistModel.es6.js
	3 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbchecklist/rbchecklist/__init__.py (Diff revision 2)
Show all issues
```
This is a breaking change, so we need to bump major.
```

Commits:

	Summary	ID
	Fix and update the rbchecklist extension for Review Board 5.0. This change updates the rbchecklist extension for Review Board 5.0.x and Django 3.2. This extension was also broken in a few ways, and I've fixed up the things that were causing it to break (some problems with error handling on the JS side, and a missing HTML element that was causing the settings page to show poorly). I'd really like to start over on this extension--what we have is both under-featured and over-complex, and the visual design is highly lacking. For now, this change gets things limping along again. Testing Done: Installed and activated the extension. Was able to use the features successfully.	7897c3fbdfc8aa01b1a44ce307fb87c36f2d13ec
	Fix and update the rbchecklist extension for Review Board 5.0. This change updates the rbchecklist extension for Review Board 5.0.x and Django 3.2. This extension was also broken in a few ways, and I've fixed up the things that were causing it to break (some problems with error handling on the JS side, and a missing HTML element that was causing the settings page to show poorly). I'd really like to start over on this extension--what we have is both under-featured and over-complex, and the visual design is highly lacking. For now, this change gets things limping along again. Testing Done: Installed and activated the extension. Was able to use the features successfully.	9e772362c2233b1d8b29d83d4b7b34e6c3c8df36

Diff:

Revision 3 (+334 -198)

Show changes

	rbchecklist/setup.py
	rbchecklist/rbchecklist/__init__.py
	rbchecklist/rbchecklist/extension.py
	rbchecklist/rbchecklist/models.py
	rbchecklist/rbchecklist/resources/__init__.py
	rbchecklist/rbchecklist/resources/checklist_item.py
	rbchecklist/rbchecklist/resources/checklist_resource.py
	rbchecklist/rbchecklist/static/js/models/checklistModel.es6.js
	3 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbchecklist/rbchecklist/resources/__init__.py (Diff revision 3)

Show all issues

do we use docstrings in __init__.py files? i've seen some places in the codebase have them and some don't. if so you could add one here

david May 31, 2022, 11:12 p.m.

We didn't before, but we have been over time. My eventual goal is to get it so we can run pydocstyle (or some customized/pluginized version of it), so good catch.

rbchecklist/rbchecklist/resources/checklist_resource.py (Diff revision 3)
Show all issues
```
add docstring
```

Commits:

	Summary	ID
	Fix and update the rbchecklist extension for Review Board 5.0. This change updates the rbchecklist extension for Review Board 5.0.x and Django 3.2. This extension was also broken in a few ways, and I've fixed up the things that were causing it to break (some problems with error handling on the JS side, and a missing HTML element that was causing the settings page to show poorly). I'd really like to start over on this extension--what we have is both under-featured and over-complex, and the visual design is highly lacking. For now, this change gets things limping along again. Testing Done: Installed and activated the extension. Was able to use the features successfully.	9e772362c2233b1d8b29d83d4b7b34e6c3c8df36
	Fix and update the rbchecklist extension for Review Board 5.0. This change updates the rbchecklist extension for Review Board 5.0.x and Django 3.2. This extension was also broken in a few ways, and I've fixed up the things that were causing it to break (some problems with error handling on the JS side, and a missing HTML element that was causing the settings page to show poorly). I'd really like to start over on this extension--what we have is both under-featured and over-complex, and the visual design is highly lacking. For now, this change gets things limping along again. Testing Done: Installed and activated the extension. Was able to use the features successfully.	035d766d122870256aa06c87ac30ccf733aa731c

Diff:

Revision 4 (+340 -194)

Show changes

	rbchecklist/setup.py
	rbchecklist/rbchecklist/__init__.py
	rbchecklist/rbchecklist/extension.py
	rbchecklist/rbchecklist/models.py
	rbchecklist/rbchecklist/resources/__init__.py
	rbchecklist/rbchecklist/resources/checklist_item.py
	rbchecklist/rbchecklist/resources/checklist_resource.py
	rbchecklist/rbchecklist/static/js/models/checklistModel.es6.js
	3 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (f51ce8a)