• 
      

    Allow the header and footer to be unset in rbt review edit.

    Review Request #12188 — Created March 21, 2022 and submitted

    Information

    RBTools
    release-3.x

    Reviewers

    rbt review edit allowed the header and footer to be set, but they then
    couldn't be unset. This was due to checking for truthiness when
    determining when to set a new value.

    Now it checks for presence in options instead. This allows callers to
    pass --header "" to unset a header.

    Tested setting and then unsetting headers and footers on a review.

    Summary ID
    Allow the header and footer to be unset in rbt review edit.
    `rbt review edit` allowed the header and footer to be set, but they then couldn't be unset. This was due to checking for truthiness when determining when to set a new value. Now it checks for presence in `options` instead. This allows callers to pass `--header ""` to unset a header.
    fd4734cf7c336f18de62a8467eb0bb6f10e580e0
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-3.x (c994558)