Summary

Update the rbcommenttype extension for Review Board 5.0

Review Request #12185 — Created March 21, 2022 and submitted May 31, 2022, 11:11 p.m.

Information

Owner

david

Repository

rb-extension-pack

Branch

master

Bugs

Depends On

Reviewers

Groups

rb-extension-pack

People

Description

This change updates the comment type extension for Review Board 5.0.x
and Django 3.2.

Testing Done

Installed and activated the comment type extension. Configured the
types, and then created comments with assigned types.

Commits

Summary	ID
Update the rbcommenttype extension for Review Board 5.0 This change updates the comment type extension for Review Board 5.0.x and Django 3.2. Testing Done: Installed and activated the comment type extension. Configured the types, and then created comments with assigned types.	12914ff9f2f75e64c96060207d95c5c06434ec33

Issues

Description	From	Last Updated
"Testing Done" is in the wrong spot.	chipx86	May 30, 2022, 11:37 a.m.
While here, grab the new logic from beanbag_tools/__init__.py. It's clearer and more future-proof. Same for all the other functions.	chipx86	March 24, 2022, 9:28 a.m.
Let's bump the version to (3, 0, 0, 0, 'alpha', 0, False) with this.	chipx86	May 30, 2022, 11:38 a.m.

flake8 passed.

JSHint passed.

rbcommenttype/rbcommenttype/__init__.py (Diff revision 1)

Show all issues

While here, grab the new logic from beanbag_tools/__init__.py. It's clearer and more future-proof.

Same for all the other functions.

Commits:

	Summary	ID
	Update the rbcommenttype extension for Review Board 5.0 This change updates the comment type extension for Review Board 5.0.x and Django 3.2. Testing Done: Installed and activated the comment type extension. Configured the types, and then created comments with assigned types.	5db3cba7105831b3191df1da658aa89888ae1daa
	Update the rbcommenttype extension for Review Board 5.0 This change updates the comment type extension for Review Board 5.0.x and Django 3.2. Testing Done: Installed and activated the comment type extension. Configured the types, and then created comments with assigned types.	9af39aa8cfdb3082f36fca4a7d670933ff9034f4

Diff:

Revision 2 (+120 -70)

Show changes

	rbcommenttype/setup.py
	rbcommenttype/rbcommenttype/__init__.py
	rbcommenttype/rbcommenttype/admin_urls.py
	rbcommenttype/rbcommenttype/extension.py
	rbcommenttype/rbcommenttype/forms.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Show all issues
```
"Testing Done" is in the wrong spot.
```

rbcommenttype/rbcommenttype/__init__.py (Diff revision 2)

Show all issues

Let's bump the version to (3, 0, 0, 0, 'alpha', 0, False) with this.

Description:

		This change updates the comment type extension for Review Board 5.0.x
		and Django 3.2.
-
-		Testing Done:
-		Installed and activated the comment type extension. Configured the
-		types, and then created comments with assigned types.

Testing Done:

	+	Installed and activated the comment type extension. Configured the
	+	types, and then created comments with assigned types.

Commits:

	Summary	ID
	Update the rbcommenttype extension for Review Board 5.0 This change updates the comment type extension for Review Board 5.0.x and Django 3.2. Testing Done: Installed and activated the comment type extension. Configured the types, and then created comments with assigned types.	9af39aa8cfdb3082f36fca4a7d670933ff9034f4
	Update the rbcommenttype extension for Review Board 5.0 This change updates the comment type extension for Review Board 5.0.x and Django 3.2. Testing Done: Installed and activated the comment type extension. Configured the types, and then created comments with assigned types.	12914ff9f2f75e64c96060207d95c5c06434ec33

Diff:

Revision 3 (+122 -72)

Show changes

	rbcommenttype/setup.py
	rbcommenttype/rbcommenttype/__init__.py
	rbcommenttype/rbcommenttype/admin_urls.py
	rbcommenttype/rbcommenttype/extension.py
	rbcommenttype/rbcommenttype/forms.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (70a6b36)