Fix return value from BaseResource.save()

 






 

 


  Review Request #12180
  —
  Created March 21, 2022 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-5.0.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
When converted to async/await, the BaseResource.save() operation lost

the return of the response object. This isn't actually used in any of

the Review Board code, but some rb-extension-pack code was using it.

This change fixes that.

 








  


 
 

  
Saw that saving templates from the checklist extension worked correctly

again.

 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Fix return value from BaseResource.save()
     
When converted to async/await, the `BaseResource.save()` operation lost
the return of the response object. This isn't actually used in any of
the Review Board code, but some rb-extension-pack code was using it.
This change fixes that.

Testing Done:
Saw that saving templates from the checklist extension worked correctly
again.

    

   
  		
  b7068de9194c87b8d6b66ed547655493aa3ede41
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/static/rb/js/resources/models/baseResourceModel.es6.js
     
    

   
  

 










     

    

   

  

  

   
   Loading...