Fix return value from BaseResource.save()

 






 

 


  Review Request #12180
  —
  Created March 21, 2022 and submitted 

 




















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-5.0.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
When converted to async/await, the BaseResource.save() operation lost

the return of the response object. This isn't actually used in any of

the Review Board code, but some rb-extension-pack code was using it.

This change fixes that.

 








  


 
 

  
Saw that saving templates from the checklist extension worked correctly

again.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     

      Fix return value from BaseResource.save()
      
When converted to async/await, the `BaseResource.save()` operation lost
the return of the response object. This isn't actually used in any of
the Review Board code, but some rb-extension-pack code was using it.
This change fixes that.

Testing Done:
Saw that saving templates from the checklist extension worked correctly
again.

     


    		
    b7068de9194c87b8d6b66ed547655493aa3ede41

   



  
 




 













 









 






  

 



















 




 




 














 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




david




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Pushed to release-5.0.x (aaaf766)





 


 










  

 









     

    

   

  

  

   
   Loading...