Summary

Enhance JSON output for rbt close.

Review Request #12167 — Created March 17, 2022 and submitted March 18, 2022, 2:20 p.m.

Information

Owner

chipx86

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

This updates the rbt close --json output to add the close description,
to rename review_request to review_request_id, and to add
review_request_url, for better reference to the review request.

It also changes status to close_type, since status is reserved and
was being overridden.

Testing Done

Tested closing with and without a description. Saw the expected output.

Commits

Summary	ID
Enhance JSON output for rbt close. This updates the `rbt close --json` output to add the close description, to rename `review_request` to `review_request_id`, and to add `review_request_url`, for better reference to the review request. It also changes `status` to `close_type`, since `status` is reserved and was being overridden.	b32ea29979769b45b475f8377188e528375246c9

flake8 passed.

JSHint passed.

Change Summary:

Fixed a key conflict with the existing status key.

Description:

		This updates the `rbt close --json` output to add the close description,
		to rename `review_request` to `review_request_id`, and to add
		`review_request_url`, for better reference to the review request.
	+
	+	It also changes `status` to `close_type`, since `status` is reserved and
	+	was being overridden.

Commits:

	Summary	ID
	Enhance JSON output for rbt close. This updates the `rbt close --json` output to add the close description, to rename `review_request` to `review_request_id`, and to add `review_request_url`, for better reference to the review request.	8f4f00f6f9143d7f0be43cad837cfdc91f01014f
	Enhance JSON output for rbt close. This updates the `rbt close --json` output to add the close description, to rename `review_request` to `review_request_id`, and to add `review_request_url`, for better reference to the review request. It also changes `status` to `close_type`, since `status` is reserved and was being overridden.	b32ea29979769b45b475f8377188e528375246c9

Diff:

Revision 2 (+18 -8)

Show changes

rbtools/commands/close.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.x (f5919c3)