Summary

Add history support in rbt attach, and enhance JSON output.

Review Request #12164 — Created March 17, 2022 and submitted March 18, 2022, 2:22 p.m.

Information

Owner

chipx86

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

This provides a couple of much-needed improvements to rbt attach.
It now supports --attachment-history-id=, which allows for specifying
the ID of a file attachment history object that should own the file
attachment. This enables callers to replace file attachments, if they
know the ID, and to set up diffing.

That's perhaps more useful for automation, so to help with that, the
JSON output has been enhanced to provide a lot more information about
the resulting attachment. This includes:

File attachment ID
File attachment History ID
Revision
Caption
Stored filename
Mimetype
Download URL
Review request URL
Review UI URL

This should be enough for automated tooling to begin operating on the
attachment further.

Along with this, the attached_file key in the JSON output is now
guaranteed to be an absolute path, which is better for automated tools.

Testing Done

Tested rbt attach with the new JSON output, with a combination of
arguments (with/without --caption and --filename).

Tested the payload with errors (invalid review request ID, filename).

Tested attaching with an attachment history ID and getting the new
revision.

Commits

Summary	ID
Add history support in rbt attach, and enhance JSON output. This provides a couple of much-needed improvements to `rbt attach`. It now supports `--attachment-history-id=`, which allows for specifying the ID of a file attachment history object that should own the file attachment. This enables callers to replace file attachments, if they know the ID, and to set up diffing. That's perhaps more useful for automation, so to help with that, the JSON output has been enhanced to provide a lot more information about the resulting attachment. This includes: * File attachment ID * File attachment History ID * Revision * Caption * Stored filename * Mimetype * Download URL * Review request URL * Review UI URL This should be enough for automated tooling to begin operating on the attachment further.	c5e5da40e69525a84d07c74ddd94cb8b0023982c

Summary

Add history support in rbt attach, and enhance JSON output.

This provides a couple of much-needed improvements to `rbt attach`. It now supports `--attachment-history-id=`, which allows for specifying the ID of a file attachment history object that should own the file attachment. This enables callers to replace file attachments, if they know the ID, and to set up diffing. That's perhaps more useful for automation, so to help with that, the JSON output has been enhanced to provide a lot more information about the resulting attachment. This includes: * File attachment ID * File attachment History ID * Revision * Caption * Stored filename * Mimetype * Download URL * Review request URL * Review UI URL This should be enough for automated tooling to begin operating on the attachment further.

c5e5da40e69525a84d07c74ddd94cb8b0023982c

Issues

Description	From	Last Updated
If this is truly for master (rbtools 4.0), just import from urllib.parse. I'll be updating things to do that everywhere …	david	March 17, 2022, 6:33 p.m.

flake8 passed.

JSHint passed.

rbtools/commands/attach.py (Diff revision 1)

Show all issues

If this is truly for master (rbtools 4.0), just import from urllib.parse. I'll be updating things to do that everywhere soon.

david March 17, 2022, 6:33 p.m.

Actually, I'm getting the sense that these are all for release-3.x (probably we just need to update .reviewboardrc).

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.x (c89e055)