Fix incorrectly detecting CVS repositories when not found.

 






 

 


  Review Request #12162
  —
  Created March 17, 2022 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  RBTools
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  rbtools
 









 
 

  
 






 








 





  


 
 

  
CVSTool.get_repository_info() was returning a RepositoryInfo result

when no repository could be found. The paths within were None, but

this was enough to trip up rbt list-repo-types (and probably other

code paths).


This change checks the path before returning a result, mirroring the

logic in most other SCMs.

 








  


 
 

  
Unit tests pass.

 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Fix incorrectly detecting CVS repositories when not found.
     
`CVSTool.get_repository_info()` was returning a `RepositoryInfo` result
when no repository could be found. The paths within were `None`, but
this was enough to trip up `rbt list-repo-types` (and probably other
code paths).

This change checks the path before returning a result, mirroring the
logic in most other SCMs.

    

   
  		
  61cbcb7390160a6b7b0d3ebde3b1ee5811d942ff
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      rbtools/clients/cvs.py
     
    

   
  

 



 

  

   
    

     
      
      rbtools/clients/tests/test_cvs.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...