• 
      

    Fix incorrectly detecting CVS repositories when not found.

    Review Request #12162 — Created March 17, 2022 and submitted

    Information

    RBTools
    master

    Reviewers

    CVSTool.get_repository_info() was returning a RepositoryInfo result
    when no repository could be found. The paths within were None, but
    this was enough to trip up rbt list-repo-types (and probably other
    code paths).

    This change checks the path before returning a result, mirroring the
    logic in most other SCMs.

    Unit tests pass.

    Summary ID
    Fix incorrectly detecting CVS repositories when not found.
    `CVSTool.get_repository_info()` was returning a `RepositoryInfo` result when no repository could be found. The paths within were `None`, but this was enough to trip up `rbt list-repo-types` (and probably other code paths). This change checks the path before returning a result, mirroring the logic in most other SCMs.
    61cbcb7390160a6b7b0d3ebde3b1ee5811d942ff
    Description From Last Updated

    This should go onto release-3.x, no?

    daviddavid
    david
    1. 
        
    2. Show all issues

      This should go onto release-3.x, no?

      1. .reviewboardrc never got updated. These are all for 3.x.

    3. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-3.x (450a6c2)