Summary

Fix building packages on Python 3.10.

Review Request #12156 — Created March 16, 2022 and submitted March 16, 2022, 3:07 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Two parts of the build process, build-i18n.py and build-media.py,

trigger the collections import issues on Python 3.10. This wasn't a

problem for releases before due to our build process favoring building

multi-version wheels with Python 2.7 and due to eggs not being built for

Python 3.x, but it's going to be a problem going forward as that logic

has changed.
We now apply all the Django Evolution patches, which includes the

collections patch, to Django before Django itself is initialized. This

ensures we can build on all supported versions of Python.

Testing Done

Successfully built packages on Python 3.10.

Commits

Summary	ID
Fix building packages on Python 3.10. Two parts of the build process, `build-i18n.py` and `build-media.py`, trigger the `collections` import issues on Python 3.10. This wasn't a problem for releases before due to our build process favoring building multi-version wheels with Python 2.7 and due to eggs not being built for Python 3.x, but it's going to be a problem going forward as that logic has changed. We now apply all the Django Evolution patches, which includes the collections patch, to Django before Django itself is initialized. This ensures we can build on all supported versions of Python.	493055b7a4d248253b5637cec0af4be31e8f2933

Summary

Fix building packages on Python 3.10.

Two parts of the build process, `build-i18n.py` and `build-media.py`, trigger the `collections` import issues on Python 3.10. This wasn't a problem for releases before due to our build process favoring building multi-version wheels with Python 2.7 and due to eggs not being built for Python 3.x, but it's going to be a problem going forward as that logic has changed. We now apply all the Django Evolution patches, which includes the collections patch, to Django before Django itself is initialized. This ensures we can build on all supported versions of Python.

493055b7a4d248253b5637cec0af4be31e8f2933

Issues

Description	From	Last Updated
E402 module level import not at top of file	reviewbot	March 16, 2022, 2:49 p.m.
E402 module level import not at top of file	reviewbot	March 16, 2022, 2:49 p.m.

flake8 failed.

JSHint passed.

flake8

contrib/internal/build-i18n.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E402 module level import not at top of file
```
contrib/internal/build-media.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E402 module level import not at top of file
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (968a768)