Fix building documentation for Review Board 5.
Review Request #12153 — Created March 14, 2022 and submitted — Latest diff uploaded
The Review Board 5 docs failed to build due to two problems:
ID collisions in the
auth_permissions
fixtures for thedocs.db
.
The fixtures no longer contain any permissions, allowing Django to
manage this completely.An
AttributeError
in thewebapidocs
Sphinx extension, where
node.slice.value
was failing whennode.slice
was aName
. In
prior versions of Python, we'd get anast.Index
when we hit this
code path, but no longer. The code now special-casesast.Index
,
and has a suitable fallback for other types.
Successfully built the docs.
Found the spots where the API docs were hitting this code path. Verified
the resulting documentation still looked correct.