flake8
failed.
JSHint
passed.
flake8
-
rbtools/clients/tests/test_git.py (Diff revision 1) Show all issues -
rbtools/clients/tests/test_git.py (Diff revision 1) E128 continuation line under-indented for visual indent
Review Request #12127 — Created March 8, 2022 and submitted
Information | |
---|---|
david | |
RBTools | |
master | |
Reviewers | |
rbtools | |
Because enterprises tend to move very slowly, we're keeping Python 2.7
compatibility for RBTools 3.0. Two issues had snuck in that were
breaking this:
- We had renamed uses of
assertRaisesRegexp
to use the new
assertRaisesRegex
name. Unfortunately, this new name is only Python
3.1+. I've changed it back, and made two uses of it instead call the
more appropriateassertRaisesMessage
helper, so now there's only
one place that hits it.- The
tqdm
library depends onimportlib_resources
. Unfortunately,
while tqdm is maintaining Python 2.7 compatibility, the newer
versions of its dependency are not. I've added a pin for the last
compatible version.
Ran
setup.py develop
under Python 2.7, and then ran all unit tests.
rbtools/clients/tests/test_git.py (Diff revision 1) |
---|
rbtools/clients/tests/test_git.py (Diff revision 1) |
---|
E128 continuation line under-indented for visual indent
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+30 -18) |