Summary

Fix compatibility with Python 2.7.

Review Request #12127 — Created March 8, 2022 and submitted March 9, 2022, 9:03 a.m.

Information

Owner

david

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

Because enterprises tend to move very slowly, we're keeping Python 2.7
compatibility for RBTools 3.0. Two issues had snuck in that were
breaking this:

We had renamed uses of assertRaisesRegexp to use the new
assertRaisesRegex name. Unfortunately, this new name is only Python
3.1+. I've changed it back, and made two uses of it instead call the
more appropriate assertRaisesMessage helper, so now there's only
one place that hits it.
The tqdm library depends on importlib_resources. Unfortunately,
while tqdm is maintaining Python 2.7 compatibility, the newer
versions of its dependency are not. I've added a pin for the last
compatible version.

Testing Done

Ran setup.py develop under Python 2.7, and then ran all unit tests.

Commits

Summary	ID
Fix compatibility with Python 2.7. Because enterprises tend to move very slowly, we're keeping Python 2.7 compatibility for RBTools 3.0. Two issues had snuck in that were breaking this: 1. We had renamed uses of `assertRaisesRegexp` to use the new `assertRaisesRegex` name. Unfortunately, this new name is only Python 3.1+. I've changed it back, and made two uses of it instead call the more appropriate `assertRaisesMessage` helper, so now there's only one place that hits it. 2. The `tqdm` library depends on `importlib_resources`. Unfortunately, while tqdm is maintaining Python 2.7 compatibility, the newer versions of its dependency are not. I've added a pin for the last compatible version. Testing Done: Ran setup.py develop under Python 2.7, and then ran all unit tests.	4f438a024a366b5b49a0c0746a15fcb0a3cc4c61

Summary

Fix compatibility with Python 2.7.

Because enterprises tend to move very slowly, we're keeping Python 2.7 compatibility for RBTools 3.0. Two issues had snuck in that were breaking this: 1. We had renamed uses of `assertRaisesRegexp` to use the new `assertRaisesRegex` name. Unfortunately, this new name is only Python 3.1+. I've changed it back, and made two uses of it instead call the more appropriate `assertRaisesMessage` helper, so now there's only one place that hits it. 2. The `tqdm` library depends on `importlib_resources`. Unfortunately, while tqdm is maintaining Python 2.7 compatibility, the newer versions of its dependency are not. I've added a pin for the last compatible version. Testing Done: Ran setup.py develop under Python 2.7, and then ran all unit tests.

4f438a024a366b5b49a0c0746a15fcb0a3cc4c61

Issues

Description	From	Last Updated
E128 continuation line under-indented for visual indent	reviewbot	March 8, 2022, 10:22 p.m.
E128 continuation line under-indented for visual indent	reviewbot	March 8, 2022, 10:22 p.m.
Can you separate these with a blank line?	chipx86	March 9, 2022, 8:57 a.m.

flake8 failed.

JSHint passed.

flake8

rbtools/clients/tests/test_git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
rbtools/clients/tests/test_git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```

Commits:

	Summary	ID
	Fix compatibility with Python 2.7. Because enterprises tend to move very slowly, we're keeping Python 2.7 compatibility for RBTools 3.0. Two issues had snuck in that were breaking this: 1. We had renamed uses of `assertRaisesRegexp` to use the new `assertRaisesRegex` name. Unfortunately, this new name is only Python 3.1+. I've changed it back, and made two uses of it instead call the more appropriate `assertRaisesMessage` helper, so now there's only one place that hits it. 2. The `tqdm` library depends on `importlib_resources`. Unfortunately, while tqdm is maintaining Python 2.7 compatibility, the newer versions of its dependency are not. I've added a pin for the last compatible version. Testing Done: Ran setup.py develop under Python 2.7, and then ran all unit tests.	de7a5839d63ec6e7d080bbb520dd8d9124a7704d
	Fix compatibility with Python 2.7. Because enterprises tend to move very slowly, we're keeping Python 2.7 compatibility for RBTools 3.0. Two issues had snuck in that were breaking this: 1. We had renamed uses of `assertRaisesRegexp` to use the new `assertRaisesRegex` name. Unfortunately, this new name is only Python 3.1+. I've changed it back, and made two uses of it instead call the more appropriate `assertRaisesMessage` helper, so now there's only one place that hits it. 2. The `tqdm` library depends on `importlib_resources`. Unfortunately, while tqdm is maintaining Python 2.7 compatibility, the newer versions of its dependency are not. I've added a pin for the last compatible version. Testing Done: Ran setup.py develop under Python 2.7, and then ran all unit tests.	4f438a024a366b5b49a0c0746a15fcb0a3cc4c61

Diff:

Revision 2 (+30 -18)

Show changes

	setup.py
	rbtools/clients/tests/test_git.py
	rbtools/testing/testcase.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

setup.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Can you separate these with a blank line?
```

Status: Closed (submitted)

Change Summary:

Pushed to master (fb453a9)

setup.py (Diff revision 2)