Fix Beanstalk post-recieve close hook.

Review Request #12124 — Created March 8, 2022 and submitted

Information

Review Board
release-5.0.x

Reviewers

The close hook for Beanstalk was apparently never actually used, because
it wasn't calling close_all_review_requests with the required
arguments. This change plumbs through the necessary things.

Ran unit tests.

Summary ID
Fix Beanstalk post-recieve close hook.
The close hook for Beanstalk was apparently never actually used, because it wasn't calling `close_all_review_requests` with the required arguments. This change plumbs through the necessary things. Testing Done: Ran unit tests.
5c065725ed665b763802a96b4aad523cc12929e7
Description From Last Updated

Missing , optional

chipx86chipx86

Can we pass these as keyword arguments? Given the same arguments are going into both variations of this, maybe we …

chipx86chipx86
chipx86
  1. 
      
  2. reviewboard/hostingsvcs/beanstalk.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
    Show all issues

    Missing , optional

  3. reviewboard/hostingsvcs/beanstalk.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
    Show all issues

    Can we pass these as keyword arguments?

    Given the same arguments are going into both variations of this, maybe we could build that up up-front and then pass in to whichever we call.

    1. I don't see any benefit to using kwargs here (it would just be a lot of repetition... payload=payload, server_url=server_url, etc.). This is also not something that is in a commonly used or changed part of the code. Same with building it ahead of time... it's just two instances. If it were 3 or more I'd say yes.

  4. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to django-3.2 (c4ed783)
Loading...