Summary:

Fix Beanstalk post-recieve close hook.

Review Request #12124 — Created March 8, 2022 and submitted March 14, 2022, 2 p.m.

Information
Owner:	david
Repository:	Review Board
Branch:	release-5.0.x
Bugs:
Depends On:
Reviewers
Groups:	reviewboard
People:

Description

The close hook for Beanstalk was apparently never actually used, because
it wasn't calling close_all_review_requests with the required
arguments. This change plumbs through the necessary things.

Testing Done

Ran unit tests.

Commits

Summary
	Fix Beanstalk post-recieve close hook.

Screenshots

Issues

Description	From	Last Updated
Missing , optional	chipx86	March 14, 2022, 8:56 a.m.
Can we pass these as keyword arguments? Given the same arguments are going into both variations of this, maybe we …	chipx86	March 14, 2022, 8:57 a.m.

flake8 passed.

JSHint passed.

reviewboard/hostingsvcs/beanstalk.py (Diff revision 1)
Show all issues
```
Missing , optional
```

reviewboard/hostingsvcs/beanstalk.py (Diff revision 1)

Show all issues

Can we pass these as keyword arguments?

Given the same arguments are going into both variations of this, maybe we could build that up up-front and then pass in to whichever we call.

david March 14, 2022, 8:57 a.m.

I don't see any benefit to using kwargs here (it would just be a lot of repetition... payload=payload, server_url=server_url, etc.). This is also not something that is in a commonly used or changed part of the code. Same with building it ahead of time... it's just two instances. If it were 3 or more I'd say yes.

Commits:

	Summary
-		Fix Beanstalk post-recieve close hook.
+		Fix Beanstalk post-recieve close hook.

Diff:

Revision 2 (+114 -18)

Show changes

reviewboard/hostingsvcs/beanstalk.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to django-3.2 (c4ed783)