Remove old encoding_list parameter to diffutils methods.

Review Request #12122 — Created March 8, 2022 and submitted — Latest diff uploaded

Information

Review Board
release-5.0.x

Reviewers

The encoding_list parameter was once used to allow us to plumb through
the list of possible encodings for files shown in the diff viewer. This
list is now computed elsewhere, but we kept the old parameters for
compatibility, with a deprecation warning. This change removes those now
that the deprecation cycle is complete.

Ran unit tests.

Diff Revision 1

This is not the most recent revision of the diff. The latest diff is revision 2. See what's changed.

orig
1
2

Commits

First Last Summary ID Author
Remove old encoding_list parameter to diffutils methods.
The `encoding_list` parameter was once used to allow us to plumb through the list of possible encodings for files shown in the diff viewer. This list is now computed elsewhere, but we kept the old parameters for compatibility, with a deprecation warning. This change removes those now that the deprecation cycle is complete. Testing Done: Ran unit tests.
a9e5649d3ad797152f26e7d4d06d40a5763c8666 David Trowbridge
reviewboard/diffviewer/diffutils.py
reviewboard/diffviewer/tests/test_diffutils.py
reviewboard/diffviewer/tests/test_forms.py
Loading...