Remove old encoding_list parameter to diffutils methods.

Review Request #12122 — Created March 8, 2022 and submitted

Information

Review Board
release-5.0.x

Reviewers

The encoding_list parameter was once used to allow us to plumb through
the list of possible encodings for files shown in the diff viewer. This
list is now computed elsewhere, but we kept the old parameters for
compatibility, with a deprecation warning. This change removes those now
that the deprecation cycle is complete.

Ran unit tests.

Summary ID
Remove old encoding_list parameter to diffutils methods.
The `encoding_list` parameter was once used to allow us to plumb through the list of possible encodings for files shown in the diff viewer. This list is now computed elsewhere, but we kept the old parameters for compatibility, with a deprecation warning. This change removes those now that the deprecation cycle is complete. Testing Done: Ran unit tests.
f6117fbe6fd5871c4e6430438a528f7edcd46c32
Description From Last Updated

Can you add a "Version Changed" noting the removal?

chipx86chipx86

Feeling like we should keep the 4.0 info and add a new block for 5.0, to keep that history. But …

chipx86chipx86

We should have a Version Changed here.

chipx86chipx86
chipx86
  1. 
      
  2. reviewboard/diffviewer/diffutils.py (Diff revision 1)
     
     
     
     
     
     
     

    Can you add a "Version Changed" noting the removal?

  3. reviewboard/diffviewer/diffutils.py (Diff revision 1)
     
     
     
     
     
     

    Feeling like we should keep the 4.0 info and add a new block for 5.0, to keep that history. But I'm not sure. If not, then maybe update the 5.0 info to say this was deprecated in 4.0.

    We haven't really gone a round on both deprecation-then-removal cycles with the version info in the description. What do you think?

    1. I'm fine leaving it.

  4. reviewboard/diffviewer/diffutils.py (Diff revision 1)
     
     
     
     
     
     
     

    We should have a Version Changed here.

  5. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to django-3.2 (47f870a)
Loading...