flake8
passed.
JSHint
passed.
Remove old encoding_list parameter to diffutils methods.
Review Request #12122 — Created March 8, 2022 and submitted
| Information | |
|---|---|
| david | |
| Review Board | |
| release-5.0.x | |
| Reviewers | |
| reviewboard | |
The
encoding_listparameter was once used to allow us to plumb through
the list of possible encodings for files shown in the diff viewer. This
list is now computed elsewhere, but we kept the old parameters for
compatibility, with a deprecation warning. This change removes those now
that the deprecation cycle is complete.
Ran unit tests.
-
-
reviewboard/diffviewer/diffutils.py (Diff revision 1) Can you add a "Version Changed" noting the removal?
-
reviewboard/diffviewer/diffutils.py (Diff revision 1) Feeling like we should keep the 4.0 info and add a new block for 5.0, to keep that history. But I'm not sure. If not, then maybe update the 5.0 info to say this was deprecated in 4.0.
We haven't really gone a round on both deprecation-then-removal cycles with the version info in the description. What do you think?
-
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+78 -174) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.