Summary

Remove old encoding_list parameter to diffutils methods.

Review Request #12122 — Created March 8, 2022 and submitted March 14, 2022, 2 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The encoding_list parameter was once used to allow us to plumb through
the list of possible encodings for files shown in the diff viewer. This
list is now computed elsewhere, but we kept the old parameters for
compatibility, with a deprecation warning. This change removes those now
that the deprecation cycle is complete.

Testing Done

Ran unit tests.

Commits

Summary	ID
Remove old encoding_list parameter to diffutils methods. The `encoding_list` parameter was once used to allow us to plumb through the list of possible encodings for files shown in the diff viewer. This list is now computed elsewhere, but we kept the old parameters for compatibility, with a deprecation warning. This change removes those now that the deprecation cycle is complete. Testing Done: Ran unit tests.	f6117fbe6fd5871c4e6430438a528f7edcd46c32

Summary

Remove old encoding_list parameter to diffutils methods.

The `encoding_list` parameter was once used to allow us to plumb through the list of possible encodings for files shown in the diff viewer. This list is now computed elsewhere, but we kept the old parameters for compatibility, with a deprecation warning. This change removes those now that the deprecation cycle is complete. Testing Done: Ran unit tests.

f6117fbe6fd5871c4e6430438a528f7edcd46c32

Issues

Description	From	Last Updated
Can you add a "Version Changed" noting the removal?	chipx86	March 14, 2022, 8:55 a.m.
Feeling like we should keep the 4.0 info and add a new block for 5.0, to keep that history. But …	chipx86	March 14, 2022, 8:53 a.m.
We should have a Version Changed here.	chipx86	March 14, 2022, 8:54 a.m.

flake8 passed.

JSHint passed.

reviewboard/diffviewer/diffutils.py (Diff revision 1)

The issue has been resolved. Show all issues

Can you add a "Version Changed" noting the removal?

reviewboard/diffviewer/diffutils.py (Diff revision 1)

The issue has been resolved. Show all issues

Feeling like we should keep the 4.0 info and add a new block for 5.0, to keep that history. But I'm not sure. If not, then maybe update the 5.0 info to say this was deprecated in 4.0.

We haven't really gone a round on both deprecation-then-removal cycles with the version info in the description. What do you think?

david March 14, 2022, 8:54 a.m.
```
I'm fine leaving it.
```

reviewboard/diffviewer/diffutils.py (Diff revision 1)

The issue has been resolved. Show all issues

We should have a Version Changed here.

Commits:

	Summary	ID
	Remove old encoding_list parameter to diffutils methods. The `encoding_list` parameter was once used to allow us to plumb through the list of possible encodings for files shown in the diff viewer. This list is now computed elsewhere, but we kept the old parameters for compatibility, with a deprecation warning. This change removes those now that the deprecation cycle is complete. Testing Done: Ran unit tests.	a9e5649d3ad797152f26e7d4d06d40a5763c8666
	Remove old encoding_list parameter to diffutils methods. The `encoding_list` parameter was once used to allow us to plumb through the list of possible encodings for files shown in the diff viewer. This list is now computed elsewhere, but we kept the old parameters for compatibility, with a deprecation warning. This change removes those now that the deprecation cycle is complete. Testing Done: Ran unit tests.	f6117fbe6fd5871c4e6430438a528f7edcd46c32

Diff:

Revision 2 (+78 -174)

Show changes

	reviewboard/diffviewer/diffutils.py
	reviewboard/diffviewer/tests/test_diffutils.py
	reviewboard/diffviewer/tests/test_forms.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to django-3.2 (47f870a)