Summary

Add skipping for two more tests which rely on the P4 module.

Review Request #12116 — Created March 7, 2022 and submitted March 14, 2022, 2 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

There are a couple tests for the repository form which attempt to create
a Perforce-backed repository, but this fails if the P4 module is not
installed. Since there are still a few cases where we're unable to
install the P4 module, these should be marked to skip if it's not
available.

Testing Done

Ran tests without P4 installed and saw the tests appropriately skipped.

Commits

Summary	ID
Add skipping for two more tests which rely on the P4 module. There are a couple tests for the repository form which attempt to create a Perforce-backed repository, but this fails if the P4 module is not installed. Since there are still a few cases where we're unable to install the P4 module, these should be marked to skip if it's not available. Testing Done: Ran tests without P4 installed and saw the tests appropriately skipped.	03e1c4b33daf709b2185072e73275625b0674f69

Summary

Add skipping for two more tests which rely on the P4 module.

There are a couple tests for the repository form which attempt to create a Perforce-backed repository, but this fails if the P4 module is not installed. Since there are still a few cases where we're unable to install the P4 module, these should be marked to skip if it's not available. Testing Done: Ran tests without P4 installed and saw the tests appropriately skipped.

03e1c4b33daf709b2185072e73275625b0674f69

Issues

Description	From	Last Updated
unittest should be in the standard library import group.	chipx86	March 14, 2022, 8:50 a.m.

flake8 passed.

JSHint passed.

Nit: In the description, "perforce" -> "Perforce".

reviewboard/scmtools/tests/test_repository_form.py (Diff revision 1)
Show all issues
```
unittest should be in the standard library import group.
```

Description:

		There are a couple tests for the repository form which attempt to create
~		a perforce-backed repository, but this fails if the P4 module is not
	~	a Perforce-backed repository, but this fails if the P4 module is not
		installed. Since there are still a few cases where we're unable to
		install the P4 module, these should be marked to skip if it's not
		available.

Commits:

	Summary	ID
	Add skipping for two more tests which rely on the P4 module. There are a couple tests for the repository form which attempt to create a perforce-backed repository, but this fails if the P4 module is not installed. Since there are still a few cases where we're unable to install the P4 module, these should be marked to skip if it's not available. Testing Done: Ran tests without P4 installed and saw the tests appropriately skipped.	588d0359c40725795bbc615bee8bb190865789de
	Add skipping for two more tests which rely on the P4 module. There are a couple tests for the repository form which attempt to create a Perforce-backed repository, but this fails if the P4 module is not installed. Since there are still a few cases where we're unable to install the P4 module, these should be marked to skip if it's not available. Testing Done: Ran tests without P4 installed and saw the tests appropriately skipped.	03e1c4b33daf709b2185072e73275625b0674f69

Diff:

Revision 2 (+18)

Show changes

reviewboard/scmtools/tests/test_repository_form.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to django-3.2 (2d917ec)