Fix up a bad pathological test path.

 






 

 


  Review Request #12115
  —
  Created March 7, 2022 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-5.0.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Inside the API paginator tests, we had a code path to handle

pathological cases where we hit the paginator with an unexpected URL.

This was calling self.fail(), but the method this is in isn't a test

case, it's a paginator. This has been changed to just raise an exception

instead.

 








  


 
 

  
Ran unit tests.

 







 









 





  








 




 







   

    
    
Diff Revision 1


This is not the most recent revision of the diff. The latest diff is revision 2. See what's changed.

    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Fix up a bad pathological test path.
     
Inside the API paginator tests, we had a code path to handle
pathological cases where we hit the paginator with an unexpected URL.
This was calling `self.fail()`, but the method this is in isn't a test
case, it's a paginator. This has been changed to just raise an exception
instead.

Testing Done:
Ran unit tests.

    

   
  		
  95603f460ffb910dceaeeee2430c1bcdaaffa007
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/hostingsvcs/tests/test_api_paginator.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...