Summary

Fix up a bad pathological test path.

Review Request #12115 — Created March 7, 2022 and submitted March 14, 2022, 2 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Inside the API paginator tests, we had a code path to handle
pathological cases where we hit the paginator with an unexpected URL.
This was calling self.fail(), but the method this is in isn't a test
case, it's a paginator. This has been changed to just raise an exception
instead.

Testing Done

Ran unit tests.

Commits

Summary	ID
Fix up a bad pathological test path. Inside the API paginator tests, we had a code path to handle pathological cases where we hit the paginator with an unexpected URL. This was calling `self.fail()`, but the method this is in isn't a test case, it's a paginator. This has been changed to just raise an exception instead. Testing Done: Ran unit tests.	ed6ad367a004b8a50659a28602613693ef1a0bd4

Issues

Description	From	Last Updated
Let's raise AssertionError.	chipx86	March 14, 2022, 8:47 a.m.

flake8 passed.

JSHint passed.

reviewboard/hostingsvcs/tests/test_api_paginator.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Let's raise AssertionError.
```

Commits:

	Summary	ID
	Fix up a bad pathological test path. Inside the API paginator tests, we had a code path to handle pathological cases where we hit the paginator with an unexpected URL. This was calling `self.fail()`, but the method this is in isn't a test case, it's a paginator. This has been changed to just raise an exception instead. Testing Done: Ran unit tests.	95603f460ffb910dceaeeee2430c1bcdaaffa007
	Fix up a bad pathological test path. Inside the API paginator tests, we had a code path to handle pathological cases where we hit the paginator with an unexpected URL. This was calling `self.fail()`, but the method this is in isn't a test case, it's a paginator. This has been changed to just raise an exception instead. Testing Done: Ran unit tests.	ed6ad367a004b8a50659a28602613693ef1a0bd4

Diff:

Revision 2 (+2 -2)

Show changes

reviewboard/hostingsvcs/tests/test_api_paginator.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to django-3.2 (dfb3ebc)