Do some code housekeeping.
Review Request #12110 — Created March 7, 2022 and submitted — Latest diff uploaded
This change does a whole bunch of small cleanups:
- Fix up a bunch of issues with indentation, wrapping, and blank lines.
- Remove a lot of dead code.
- Always use
clsas the bound variable for class methods. - Add in a few checks and assignments to prevent potentially unbound
variable accesses in pathological cases.
Ran unit tests.
Diff Revision 2 (Latest)
orig
1
2
Commits
Files
| reviewboard/webapi/resources/review_request.py |
|---|
| reviewboard/webapi/resources/review_request_draft.py |
|---|
| reviewboard/webapi/resources/user_file_attachment.py |
|---|
| reviewboard/webapi/tests/mixins.py |
|---|
| reviewboard/webapi/tests/test_base.py |
|---|
| reviewboard/webapi/tests/test_default_reviewer.py |
|---|
| reviewboard/webapi/tests/test_diffcommit.py |
|---|
| reviewboard/webapi/tests/test_repository.py |
|---|
| reviewboard/webapi/tests/test_repository_branches.py |
|---|
| reviewboard/webapi/tests/test_review_comment.py |
|---|
| reviewboard/webapi/tests/test_review_general_comment.py |
|---|
| reviewboard/webapi/tests/test_review_reply_diff_comment.py |
|---|
| reviewboard/webapi/tests/test_review_reply_general_comment.py |
|---|
| reviewboard/webapi/tests/test_review_reply_screenshot_comment.py |
|---|
| reviewboard/webapi/tests/test_review_request.py |
|---|
| reviewboard/webapi/tests/test_review_screenshot_comment.py |
|---|
| reviewboard/webapi/tests/test_screenshot_draft.py |
|---|