Summary:

Do some code housekeeping.

Review Request #12110 — Created March 7, 2022 and submitted March 14, 2022, 8:44 a.m.

Information
Owner:	david
Repository:	Review Board
Branch:	release-5.0.x
Bugs:
Depends On:
Reviewers
Groups:	reviewboard
People:

Description

This change does a whole bunch of small cleanups:

Fix up a bunch of issues with indentation, wrapping, and blank lines.
Remove a lot of dead code.
Always use cls as the bound variable for class methods.
Add in a few checks and assignments to prevent potentially unbound

  variable accesses in pathological cases.

Testing Done

Ran unit tests.

Commits

Summary
	Do some code housekeeping.

Screenshots

Issues

Description	From	Last Updated
Can you add an Args while here?	chipx86	March 7, 2022, 4:53 p.m.
While here, let's add the missing blank line between the class docstring and member.	chipx86	March 7, 2022, 4:53 p.m.

flake8 passed.

JSHint passed.

reviewboard/avatars/services.py (Diff revision 1)

Show all issues

Can you add an Args while here?

reviewboard/webapi/tests/mixins.py (Diff revision 1)

Show all issues

While here, let's add the missing blank line between the class docstring and member.

Commits:

	Summary
-		Do some code housekeeping.
+		Do some code housekeeping.

Diff:

Revision 2 (+394 -380)

Show changes

	reviewboard/admin/siteconfig.py
	reviewboard/attachments/forms.py
	reviewboard/avatars/services.py
	reviewboard/datagrids/columns.py
	reviewboard/diffviewer/chunk_generator.py
	reviewboard/diffviewer/processors.py
	reviewboard/diffviewer/models/filediff.py
	reviewboard/diffviewer/tests/test_raw_diff_chunk_generator.py
	49 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to django-3.2 (bb151f7)