Do some code housekeeping.

Review Request #12110 — Created March 7, 2022 and submitted

Information

Review Board
release-5.0.x

Reviewers

This change does a whole bunch of small cleanups:

  • Fix up a bunch of issues with indentation, wrapping, and blank lines.
  • Remove a lot of dead code.
  • Always use cls as the bound variable for class methods.
  • Add in a few checks and assignments to prevent potentially unbound
    variable accesses in pathological cases.

Ran unit tests.

Summary ID
Do some code housekeeping.
This change does a whole bunch of small cleanups: - Fix up a bunch of issues with indentation, wrapping, and blank lines. - Remove a lot of dead code. - Always use `cls` as the bound variable for class methods. - Add in a few checks and assignments to prevent potentially unbound variable accesses in pathological cases. Testing Done: Ran unit tests.
89108d90b22d12748fb16e8546df72fe254219f5
Description From Last Updated

Can you add an Args while here?

chipx86chipx86

While here, let's add the missing blank line between the class docstring and member.

chipx86chipx86
chipx86
  1. 
      
  2. reviewboard/avatars/services.py (Diff revision 1)
     
     
     
     
     
     
     
     

    Can you add an Args while here?

  3. reviewboard/webapi/tests/mixins.py (Diff revision 1)
     
     
     

    While here, let's add the missing blank line between the class docstring and member.

  4. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to django-3.2 (bb151f7)
Loading...