Do some code housekeeping.
Review Request #12110 — Created March 7, 2022 and submitted — Latest diff uploaded
This change does a whole bunch of small cleanups:
- Fix up a bunch of issues with indentation, wrapping, and blank lines.
- Remove a lot of dead code.
- Always use
clsas the bound variable for class methods. - Add in a few checks and assignments to prevent potentially unbound
variable accesses in pathological cases.
Ran unit tests.
Diff Revision 2 (Latest)
orig
1
2
Commits
Files
| reviewboard/admin/siteconfig.py |
|---|
| reviewboard/attachments/forms.py |
|---|
| reviewboard/avatars/services.py |
|---|
| reviewboard/datagrids/columns.py |
|---|
| reviewboard/diffviewer/chunk_generator.py |
|---|
| reviewboard/diffviewer/processors.py |
|---|
| reviewboard/diffviewer/models/filediff.py |
|---|
| reviewboard/diffviewer/tests/test_raw_diff_chunk_generator.py |
|---|
| reviewboard/hostingsvcs/bugzilla.py |
|---|
| reviewboard/hostingsvcs/github.py |
|---|
| reviewboard/hostingsvcs/hook_utils.py |
|---|
| reviewboard/hostingsvcs/jira.py |
|---|
| reviewboard/hostingsvcs/rbgateway.py |
|---|
| reviewboard/hostingsvcs/testing/testcases.py |
|---|
| reviewboard/hostingsvcs/tests/test_api_paginator.py |
|---|
| reviewboard/hostingsvcs/tests/test_rbgateway.py |
|---|
| reviewboard/integrations/base.py |
|---|
| reviewboard/notifications/email/__init__.py |
|---|
| reviewboard/notifications/tests/test_email_sending.py |
|---|
| reviewboard/notifications/tests/test_webhooks.py |
|---|