Do some code housekeeping.

 






 

 


  Review Request #12110
  —
  Created March 7, 2022 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-5.0.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This change does a whole bunch of small cleanups:


    

  • Fix up a bunch of issues with indentation, wrapping, and blank lines.
    • 

  • Remove a lot of dead code.
    • 

  • Always use cls as the bound variable for class methods.
    • 

  • Add in a few checks and assignments to prevent potentially unbound
    
  variable accesses in pathological cases.
    • 


 








  


 
 

  
Ran unit tests.

 







 









 





  








 




 







   

    
    
Changes between revision 1 and 2



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Do some code housekeeping.
     
This change does a whole bunch of small cleanups:

- Fix up a bunch of issues with indentation, wrapping, and blank lines.
- Remove a lot of dead code.
- Always use `cls` as the bound variable for class methods.
- Add in a few checks and assignments to prevent potentially unbound
  variable accesses in pathological cases.

Testing Done:
Ran unit tests.

    

   
  		
  87df26e12544344ca718f52882e95d2973f34fda
  David Trowbridge
 


 
  
 
 
  
   
    

     Do some code housekeeping.
     
This change does a whole bunch of small cleanups:

- Fix up a bunch of issues with indentation, wrapping, and blank lines.
- Remove a lot of dead code.
- Always use `cls` as the bound variable for class methods.
- Add in a few checks and assignments to prevent potentially unbound
  variable accesses in pathological cases.

Testing Done:
Ran unit tests.

    

   
  		
  89108d90b22d12748fb16e8546df72fe254219f5
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/avatars/services.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/tests/mixins.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...