Get rid of legacy admin widget support.

Review Request #12108 — Created March 7, 2022 and submitted — Latest diff uploaded

Information

Review Board
release-5.0.x

Reviewers

This change ports our two remaining legacy widgets (server cache and
activity graph) to inherit from BaseAdminWidget instead of the old
legacy Widget class, and then removes support for the legacy mode.

The server activity graph has additionally been ported to use the new JS
model/view architecture. As part of this, I've modernized the code a bit
but haven't spent any time redesigning the functionality or look.

Loaded the admin site and interacted with the widgets.

Diff Revision 2 (Latest)

orig
1
2

Commits

First Last Summary ID Author
Get rid of legacy admin widget support.
This change ports our two remaining legacy widgets (server cache and activity graph) to inherit from `BaseAdminWidget` instead of the old legacy `Widget` class, and then removes support for the legacy mode. The server activity graph has additionally been ported to use the new JS model/view architecture. As part of this, I've modernized the code a bit but haven't spent any time redesigning the functionality or look. Testing Done: Loaded the admin site and interacted with the widgets.
81f86d0869c5c83f2b5d6e4fe36108443849277c David Trowbridge
reviewboard/staticbundles.py
reviewboard/admin/widgets.py
reviewboard/admin/tests/test_legacy_widgets.py
reviewboard/extensions/hooks.py
reviewboard/extensions/tests/test_admin_widget_hook.py
reviewboard/static/rb/css/pages/admin/dashboard.less
reviewboard/static/rb/js/admin/models/serverActivityWidgetModel.es6.js
reviewboard/static/rb/js/admin/views/serverActivityWidgetView.es6.js
reviewboard/templates/admin/legacy_admin_widget.html
reviewboard/templates/admin/server_cache.html
reviewboard/templates/admin/widgets/w-server-cache.html
reviewboard/templates/admin/widgets/w-stats-large.html
Loading...