flake8
passed.
JSHint
failed.
JSHint
-
reviewboard/static/rb/js/admin/views/serverActivityWidgetView.es6.js (Diff revision 1) Show all issues
Get rid of legacy admin widget support.
Review Request #12108 — Created March 7, 2022 and submitted
| Information | |
|---|---|
| david | |
| Review Board | |
| release-5.0.x | |
| Reviewers | |
| reviewboard | |
This change ports our two remaining legacy widgets (server cache and
activity graph) to inherit fromBaseAdminWidgetinstead of the old
legacyWidgetclass, and then removes support for the legacy mode.The server activity graph has additionally been ported to use the new JS
model/view architecture. As part of this, I've modernized the code a bit
but haven't spent any time redesigning the functionality or look.
Loaded the admin site and interacted with the widgets.
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+884 -1190) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
reviewboard/extensions/hooks.py (Diff revision 2) Just one
:The previous one is a typo. Mind fixing it?