Summary

Get rid of legacy admin widget support.

Review Request #12108 — Created March 7, 2022 and submitted March 7, 2022, 4:51 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change ports our two remaining legacy widgets (server cache and
activity graph) to inherit from BaseAdminWidget instead of the old
legacy Widget class, and then removes support for the legacy mode.

The server activity graph has additionally been ported to use the new JS
model/view architecture. As part of this, I've modernized the code a bit
but haven't spent any time redesigning the functionality or look.

Testing Done

Loaded the admin site and interacted with the widgets.

Commits

Summary	ID
Get rid of legacy admin widget support. This change ports our two remaining legacy widgets (server cache and activity graph) to inherit from `BaseAdminWidget` instead of the old legacy `Widget` class, and then removes support for the legacy mode. The server activity graph has additionally been ported to use the new JS model/view architecture. As part of this, I've modernized the code a bit but haven't spent any time redesigning the functionality or look. Testing Done: Loaded the admin site and interacted with the widgets.	81f86d0869c5c83f2b5d6e4fe36108443849277c

Summary

Get rid of legacy admin widget support.

This change ports our two remaining legacy widgets (server cache and activity graph) to inherit from `BaseAdminWidget` instead of the old legacy `Widget` class, and then removes support for the legacy mode. The server activity graph has additionally been ported to use the new JS model/view architecture. As part of this, I've modernized the code a bit but haven't spent any time redesigning the functionality or look. Testing Done: Loaded the admin site and interacted with the widgets.

81f86d0869c5c83f2b5d6e4fe36108443849277c

Issues

Description	From	Last Updated
Col: 77 Missing semicolon.	reviewbot	March 7, 2022, 2:29 p.m.
Just one : The previous one is a typo. Mind fixing it?	chipx86	March 7, 2022, 4:50 p.m.

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/admin/views/serverActivityWidgetView.es6.js (Diff revision 1)
Show all issues
```
Col: 77
 Missing semicolon.
```

Commits:

	Summary	ID
	Get rid of legacy admin widget support. This change ports our two remaining legacy widgets (server cache and activity graph) to inherit from `BaseAdminWidget` instead of the old legacy `Widget` class, and then removes support for the legacy mode. The server activity graph has additionally been ported to use the new JS model/view architecture. As part of this, I've modernized the code a bit but haven't spent any time redesigning the functionality or look. Testing Done: Loaded the admin site and interacted with the widgets.	f84d5960c4551b6b60ad2cefcdaee40f87bce38b
	Get rid of legacy admin widget support. This change ports our two remaining legacy widgets (server cache and activity graph) to inherit from `BaseAdminWidget` instead of the old legacy `Widget` class, and then removes support for the legacy mode. The server activity graph has additionally been ported to use the new JS model/view architecture. As part of this, I've modernized the code a bit but haven't spent any time redesigning the functionality or look. Testing Done: Loaded the admin site and interacted with the widgets.	81f86d0869c5c83f2b5d6e4fe36108443849277c

Diff:

Revision 2 (+884 -1190)

Show changes

	reviewboard/staticbundles.py
	reviewboard/admin/widgets.py
	reviewboard/admin/tests/test_legacy_widgets.py
	reviewboard/extensions/hooks.py
	reviewboard/extensions/tests/test_admin_widget_hook.py
	reviewboard/static/rb/css/pages/admin/dashboard.less
	reviewboard/static/rb/js/admin/models/serverActivityWidgetModel.es6.js
	reviewboard/static/rb/js/admin/views/serverActivityWidgetView.es6.js
	4 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

reviewboard/extensions/hooks.py (Diff revision 2)

Show all issues

Just one :

The previous one is a typo. Mind fixing it?

Status: Closed (submitted)

Change Summary:

Pushed to django-3.2 (f8e266a)