Mark HTML row data as safe in repository admin list.

 






 

 


  Review Request #12107
  —
  Created March 7, 2022 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-5.0.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
The list of repositories in the admin includes one column which contains

HTML, for the "Hooks" and "RBTools Setup" buttons. The new version of

Django was escaping these because the old allow_tags property has been

removed. This can be solved by marking the content as safe first.

 








  


 
 

  
Looked at repository list and saw buttons instead of HTML.

 







 









 





  








 




 







   

    
    
Changes between revision 1 and 2



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Mark HTML row data as safe in repository admin list.
     
The list of repositories in the admin includes one column which contains
HTML, for the "Hooks" and "RBTools Setup" buttons. The new version of
Django was escaping these, which can be solved by marking the content as
safe first.

Testing Done:
Looked at repository list and saw buttons instead of HTML.

    

   
  		
  4e23d415d57752303ed33a03a5e295026da77a7f
  David Trowbridge
 


 
  
 
 
  
   
    

     Mark HTML row data as safe in repository admin list.
     
The list of repositories in the admin includes one column which contains
HTML, for the "Hooks" and "RBTools Setup" buttons. The new version of
Django was escaping these because the old `allow_tags` property has been
removed. This can be solved by marking the content as safe first.

Testing Done:
Looked at repository list and saw buttons instead of HTML.

    

   
  		
  cd5740fd1cd22a857ac70211484ae69393cdf39f
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/reviews/models/screenshot.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/admin.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...