flake8
passed.
JSHint
passed.
Mark HTML row data as safe in repository admin list.
Review Request #12107 — Created March 7, 2022 and submitted
| Information | |
|---|---|
| david | |
| Review Board | |
| release-5.0.x | |
| Reviewers | |
| reviewboard | |
The list of repositories in the admin includes one column which contains
HTML, for the "Hooks" and "RBTools Setup" buttons. The new version of
Django was escaping these because the oldallow_tagsproperty has been
removed. This can be solved by marking the content as safe first.
Looked at repository list and saw buttons instead of HTML.
| Summary | |
|---|---|
| Description | From | Last Updated |
|---|---|---|
|
You can get rid of allow_tags. It was deprecated, and is the reason this regressed. We should audit Djblet and … |
 chipx86
|
-
-
reviewboard/scmtools/admin.py (Diff revision 1) You can get rid of
allow_tags. It was deprecated, and is the reason this regressed.We should audit Djblet and RB for this.
Description: |
|
||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commits: |
|
||||||||||||||||||
Diff: |
Revision 2 (+16 -10) |
||||||||||||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.