Allow repositories and servers to be defined in separate JSON files.

Review Request #12100 — Created March 4, 2022 and submitted

Information

ReviewBot
release-3.0.x

Reviewers

This introduces two new settings: reviewboard_servers_config_path and
repositories_config_path. These are used to point to user-defined JSON
files for Review Board servers and repositories, respectively.

The primary reason for these files is to allow the upcoming Docker
images to point to volume mounts for these configuration files,
separating the configuration in the images (for executable paths and
other settings) from any user-specified lists of servers and
repositories.

The configuration loader will parse these files and append the results
to the reviewboard_servers and repositories lists. This means that
the repository support doesn't have to know anything about these files.
It's purely contained in the configuration loader.

Documentation has been updated to cover these new options and to provide
examples.

Unit tests have also been added to test validation and loading of these
files.

Unit tests passed.

Tested these settings in the upcoming Docker images.

Built the docs and checked that the results appeared correct.

Summary ID
Allow repositories and servers to be defined in separate JSON files.
This introduces two new settings: `reviewboard_servers_config_path` and `repositories_config_path`. These are used to point to user-defined JSON files for Review Board servers and repositories, respectively. The primary reason for these files is to allow the upcoming Docker images to point to volume mounts for these configuration files, separating the configuration in the images (for executable paths and other settings) from any user-specified lists of servers and repositories. The configuration loader will parse these files and append the results to the `reviewboard_servers` and `repositories` lists. This means that the repository support doesn't have to know anything about these files. It's purely contained in the configuration loader. Documentation has been updated to cover these new options and to provide examples. Unit tests have also been added to test validation and loading of these files.
c96093cd16ca42440f7ccdfa421187a8fb56d766
Description From Last Updated

E501 line too long (84 > 79 characters)

reviewbotreviewbot

F841 local variable 'config_file' is assigned to but never used

reviewbotreviewbot

F841 local variable 'config_file' is assigned to but never used

reviewbotreviewbot

F841 local variable 'config_file' is assigned to but never used

reviewbotreviewbot

F841 local variable 'config_file' is assigned to but never used

reviewbotreviewbot

F841 local variable 'config_file' is assigned to but never used

reviewbotreviewbot

F841 local variable 'config_file' is assigned to but never used

reviewbotreviewbot

F841 local variable 'config_file' is assigned to but never used

reviewbotreviewbot

F841 local variable 'config_file' is assigned to but never used

reviewbotreviewbot

F841 local variable 'config_file' is assigned to but never used

reviewbotreviewbot

F841 local variable 'config_file' is assigned to but never used

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-3.0.x (4b4574d)