Summary:

Add a standard function for correctly applying a patch.

Review Request #12087 — Created Feb. 25, 2022 and submitted March 2, 2022, 12:42 a.m.

Information
Owner:	chipx86
Repository:	ReviewBot
Branch:	release-3.0.x
Bugs:
Depends On:
Reviewers
Groups:	reviewbot
People:

Description

This introduces File.apply_patch(), which will apply patched file
content to the filesystem for full-repository tools. This takes care of
properly applying not just added/modified changes (which worked fine
before) but deleted, moved, and copied files (which didn't).

In the future, we may want to switch this to applying a patch through
GNU patch, to take advanage of time-tested patching logic. For now,
that's not how Review Bot works, so we're mimicking the logic we most
need for our tools.

Testing Done

New unit tests pass.

Commits

Summary
	Add a standard function for correctly applying a patch.

Screenshots

Issues

Description	From	Last Updated
F841 local variable 'docs_dir' is assigned to but never used	reviewbot	Feb. 25, 2022, 7:40 p.m.
F841 local variable 'docs_dir' is assigned to but never used	reviewbot	Feb. 25, 2022, 7:42 p.m.

flake8 failed.

JSHint passed.

flake8

bot/reviewbot/processing/tests/test_file.py (Diff revision 1)
Show all issues
```
F841 local variable 'docs_dir' is assigned to but never used
```
bot/reviewbot/processing/tests/test_file.py (Diff revision 1)
Show all issues
```
F841 local variable 'docs_dir' is assigned to but never used
```

Change Summary:

Removed unused variables.

Commits:

	Summary
-		Add a standard function for correctly applying a patch.
+		Add a standard function for correctly applying a patch.

Diff:

Revision 2 (+664 -18)

Show changes

	bot/reviewbot/processing/review.py
	bot/reviewbot/processing/tests/test_file.py
	bot/reviewbot/tools/base/mixins.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Added the missing working directory to the call to apply_patch().

Commits:

	Summary
-		Add a standard function for correctly applying a patch.
+		Add a standard function for correctly applying a patch.

Diff:

Revision 3 (+664 -18)

Show changes

	bot/reviewbot/processing/review.py
	bot/reviewbot/processing/tests/test_file.py
	bot/reviewbot/tools/base/mixins.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

```
Ship It!
```

Change Summary:

Fixed incorrect setting of patched_file_path after patch.

Commits:

	Summary
-		Add a standard function for correctly applying a patch.
+		Add a standard function for correctly applying a patch.

Diff:

Revision 4 (+664 -18)

Show changes

	bot/reviewbot/processing/review.py
	bot/reviewbot/processing/tests/test_file.py
	bot/reviewbot/tools/base/mixins.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (c5bb722)