Fix callback adapter for ready() methods.

Review Request #12080 — Created Feb. 24, 2022 and submitted

Information

Review Board
release-5.0.x

Reviewers

The boilerplate that I used for all the callbacks-to-promises
conversions works in almost every case, but the ready() method is a
bit special because the callback name is ready instead of success.
The promiseToCallbacks adapter handled this, but the call sites inside
of the ready methods weren't testing for that callback name, so it
wouldn't work properly when calling in the old style.

Used an extension that called ready() on a draft review using the
callbacks style instead of promises. Saw that it worked correctly.

Summary ID
Fix callback adapter for ready() methods.
The boilerplate that I used for all the callbacks-to-promises conversions works in almost every case, but the `ready()` method is a bit special because the callback name is `ready` instead of `success`. The `promiseToCallbacks` adapter handled this, but the call sites inside of the `ready` methods weren't testing for that callback name, so it wouldn't work properly when calling in the old style. Testing Done: Used an extension that called `ready()` on a draft review using the callbacks style instead of promises. Saw that it worked correctly.
0ef57e60b1d3fd861fba5b085b346f8bc97c27ab
chipx86
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to django-3.2 (691fe49)