Summary

Do some code housecleaning.

Review Request #12079 — Created Feb. 23, 2022 and submitted March 4, 2022, 3:01 p.m.

Information

Owner

david

Repository

Djblets

Branch

release-3.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

This change just makes some relatively mechanical cleanups:

Fix iteration of TEMPLATES default to not try to iterate over None
Remove or add blank lines and spaces to conform to python style
standards.
Remove some unused variable definitions.
Always use cls as the bound variable for classmethods.
Fix a place where we were catching a URLError but then accessing
data that's only available on HTTPError.

Testing Done

Ran unit tests.

Commits

Summary	ID
Do some code housecleaning. This change just makes some relatively mechanical cleanups: - Fix iteration of TEMPLATES default to not try to iterate over `None` - Remove or add blank lines and spaces to conform to python style standards. - Remove some unused variable definitions. - Always use `cls` as the bound variable for classmethods. - Fix a place where we were catching a `URLError` but then accessing data that's only available on `HTTPError`. Testing Done: Ran unit tests.	64036f6eee4f400ac64922dc37098a293c161298

Summary

Do some code housecleaning.

This change just makes some relatively mechanical cleanups: - Fix iteration of TEMPLATES default to not try to iterate over `None` - Remove or add blank lines and spaces to conform to python style standards. - Remove some unused variable definitions. - Always use `cls` as the bound variable for classmethods. - Fix a place where we were catching a `URLError` but then accessing data that's only available on `HTTPError`. Testing Done: Ran unit tests.

64036f6eee4f400ac64922dc37098a293c161298

Issues

Description	From	Last Updated
Is this correct? We usually have 1 blank line between the module docstring and, say, imports, but then 2 blank …	chipx86	March 4, 2022, 2:49 p.m.
I think 1 was correct here.	chipx86	March 4, 2022, 2:49 p.m.
I think 1 was correct here.	chipx86	March 4, 2022, 2:49 p.m.

flake8 passed.

JSHint passed.

djblets/registries/errors.py (Diff revision 1)

The issue has been dropped. Show all issues

Is this correct? We usually have 1 blank line between the module docstring and, say, imports, but then 2 blank lines between classes/the import section/etc. I think 1 is correct here.

david March 4, 2022, 2:49 p.m.

I'm not sure why imports are treated differently but flake8 is saying two is appropriate.

chipx86 March 4, 2022, 2:49 p.m.

Weird. Okay, well, I don't want to fight flake8 on this.

djblets/util/humanize.py (Diff revision 1)
The issue has been dropped. Show all issues
```
I think 1 was correct here.
```
djblets/webapi/errors.py (Diff revision 1)
The issue has been dropped. Show all issues
```
I think 1 was correct here.
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.x (45e7295)