Fix up some string type issues.

Review Request #12078 — Created Feb. 23, 2022 and submitted

Information

Djblets
release-3.x

Reviewers

This change fixes up three issues I encountered with string types:

  • The logging method for missing cache keys in the large data utilities
    was mixing str and bytes.
  • The documentation for the return value of make_cache_key wasn't correct.
  • The new template loader for extension templates was returning contents
    as bytes, which caused problems when they were rendered (the
    resulting rendered string would include b'' around the content).
  • The WS_RE regexp used in the djblets_utils templatetags was
    incorrectly not marked as a raw string.
  • Ran unit tests.
  • Used templates from an extension and saw them render correctly.
Summary ID
Fix up some string type issues.
This change fixes up three issues I encountered with string types: - The logging method for missing cache keys in the large data utilities was mixing str and bytes. - The documentation for the return value of `make_cache_key` wasn't correct. - The new template loader for extension templates was returning contents as `bytes`, which caused problems when they were rendered (the resulting rendered string would include `b''` around the content). - The `WS_RE` regexp used in the `djblets_utils` templatetags was incorrectly not marked as a raw string. Testing Done: - Ran unit tests. - Used templates from an extension and saw them render correctly.
f10ab96c45c6a82e770ea2ec511bd4a5b6581be7
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-3.x (8b0a8ab)