Summary

Track the status of a File and normalize file paths.

Review Request #12074 — Created Feb. 23, 2022 and submitted Feb. 25, 2022, 7:07 p.m.

Information

Owner

chipx86

Repository

ReviewBot

Branch

release-3.0.x

Bugs

Depends On

Reviewers

Groups

reviewbot

People

Description

File now tracks the status from a FileDiff (the
created/deleted/modified/copied/moved states), which we'll be able to
use to make smart decisions when applying changes to files.

It also normalizes the file paths, ensuring that they're in the format
required for the OS and that all relative components have been
collapsed.

Testing Done

Relevant unit tests pass (can't currently run the whole suite).

Commits

Summary	ID
Track the status of a File and normalize file paths. `File` now tracks the status from a `FileDiff` (the created/deleted/modified/copied/moved states), which we'll be able to use to make smart decisions when applying changes to files. It also normalizes the file paths, ensuring that they're in the format required for the OS and that all relative components have been collapsed.	ce0e2bba75824b98f75d908c0dbadf45eeabfd39

Issues

Description	From	Last Updated
F401 'reviewbot.utils.filesystem.ensure_dirs_exist' imported but unused	reviewbot	Feb. 23, 2022, 7:37 p.m.

flake8 failed.

JSHint passed.

flake8

bot/reviewbot/processing/review.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'reviewbot.utils.filesystem.ensure_dirs_exist' imported but unused
```

Change Summary:

Removed an unused import.

Commits:

	Summary	ID
	Track the status of a File and normalize file paths. `File` now tracks the status from a `FileDiff` (the created/deleted/modified/copied/moved states), which we'll be able to use to make smart decisions when applying changes to files. It also normalizes the file paths, ensuring that they're in the format required for the OS and that all relative components have been collapsed.	5661af2e5f98c1d03a8708de77179a0a21dee2e8
	Track the status of a File and normalize file paths. `File` now tracks the status from a `FileDiff` (the created/deleted/modified/copied/moved states), which we'll be able to use to make smart decisions when applying changes to files. It also normalizes the file paths, ensuring that they're in the format required for the OS and that all relative components have been collapsed.	ce0e2bba75824b98f75d908c0dbadf45eeabfd39

Diff:

Revision 2 (+104 -12)

Show changes

bot/reviewbot/processing/review.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (0004867)