Skip patching symlinks, binary files, or unknown file changes.

Review Request #12072 — Created Feb. 23, 2022 and submitted

Information

ReviewBot
release-3.0.x

Reviewers

Review Bot was attempting to apply patches to symlinks and to binary
files, but had no means of doing so. For the kinds of tools that are run
by Review Bot, we shouldn't usually care much about these types of
changes.

An argument can be made for symlinks, but we're currently unable to
guarantee we'll apply these right, and symlink target support hasn't
been available until Review Board 4.0.6 anyway.

This change skips these file types, and skips unknown FileDiff status
codes, in order to minimize the kinds of changes that need to be patched
to the tree or passed to tools.

Relevant unit tests pass.

Summary ID
Skip patching symlinks, binary files, or unknown file changes.
Review Bot was attempting to apply patches to symlinks and to binary files, but had no means of doing so. For the kinds of tools that are run by Review Bot, we shouldn't usually care much about these types of changes. An argument can be made for symlinks, but we're currently unable to guarantee we'll apply these right, and symlink target support hasn't been available until Review Board 4.0.6 anyway. This change skips these file types, and skips unknown FileDiff status codes, in order to minimize the kinds of changes that need to be patched to the tree or passed to tools.
a0626dc0e99818218314845cf3042cd3b5a21340
Description From Last Updated

F401 'os' imported but unused

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-3.0.x (1bd8aab)