Summary

Fix a crash during patching when MySQL support isn't available.

Review Request #12070 — Created Feb. 21, 2022 and submitted Feb. 28, 2022, 6:01 p.m.

Information

Owner

chipx86

Repository

Django Evolution

Branch

release-2.x

Bugs

Depends On

Reviewers

Groups

django-evolution

People

Description

Django Evolution 2.1.3 introduced a patch for modern versions of
mysqlclient on Django < 2.0. The patch tried to handle the situation
where mysqlclient wasn't installed, but it didn't catch the right
exception.

This change adds a more broad exception handler, and also exception
handlers in the patch loader, one wrapping needs_patch() and one
wrapping apply_patch(). This will help us avoid other unforeseen
issues in the future.

Testing Done

Ran all unit tests without mysqlclient installed.

Commits

Summary	ID
Fix a crash during patching when MySQL support isn't available. Django Evolution 2.1.3 introduced a patch for modern versions of `mysqlclient` on Django < 2.0. The patch tried to handle the situation where `mysqlclient` wasn't installed, but it didn't catch the right exception. This change adds a more broad exception handler, and also exception handlers in the patch loader, one wrapping `needs_patch()` and one wrapping `apply_patch()`. This will help us avoid other unforeseen issues in the future.	3c49925398b8dd2b0fc376018f30bc67de8cc36d

Summary

Fix a crash during patching when MySQL support isn't available.

Django Evolution 2.1.3 introduced a patch for modern versions of `mysqlclient` on Django < 2.0. The patch tried to handle the situation where `mysqlclient` wasn't installed, but it didn't catch the right exception. This change adds a more broad exception handler, and also exception handlers in the patch loader, one wrapping `needs_patch()` and one wrapping `apply_patch()`. This will help us avoid other unforeseen issues in the future.

3c49925398b8dd2b0fc376018f30bc67de8cc36d

Issues

Description	From	Last Updated
F841 local variable 'needs_patch' is assigned to but never used	reviewbot	Feb. 21, 2022, 6:46 p.m.
F401 'django.core.exceptions.ImproperlyConfigured' imported but unused	reviewbot	Feb. 21, 2022, 6:46 p.m.

flake8 failed.

JSHint passed.

flake8

django_evolution/compat/patches/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F841 local variable 'needs_patch' is assigned to but never used
```
django_evolution/compat/patches/mysqlclient_django_pre_2_encoder_bytes.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'django.core.exceptions.ImproperlyConfigured' imported but unused
```

Change Summary:


Removed an unused import.
Removed a double call to needs_patch().

Commits:

	Summary	ID
	Fix a crash during patching when MySQL support isn't available. Django Evolution 2.1.3 introduced a patch for modern versions of `mysqlclient` on Django < 2.0. The patch tried to handle the situation where `mysqlclient` wasn't installed, but it didn't catch the right exception. This change adds a more broad exception handler, and also exception handlers in the patch loader, one wrapping `needs_patch()` and one wrapping `apply_patch()`. This will help us avoid other unforeseen issues in the future.	c04620a25bba76647e77eeab5db5fe634cf59257
	Fix a crash during patching when MySQL support isn't available. Django Evolution 2.1.3 introduced a patch for modern versions of `mysqlclient` on Django < 2.0. The patch tried to handle the situation where `mysqlclient` wasn't installed, but it didn't catch the right exception. This change adds a more broad exception handler, and also exception handlers in the patch loader, one wrapping `needs_patch()` and one wrapping `apply_patch()`. This will help us avoid other unforeseen issues in the future.	3c49925398b8dd2b0fc376018f30bc67de8cc36d

Diff:

Revision 2 (+86 -8)

Show changes

	django_evolution/compat/patches/__init__.py
	django_evolution/compat/patches/mysqlclient_django_pre_2_encoder_bytes.py
	docs/releasenotes/2.1.4.rst
	docs/releasenotes/index.rst

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.1.x (9c35ac6)