Add extraction of UNIX file modes and symlink targets from Git diffs.

 






 

 


  Review Request #12069
  —
  Created Feb. 20, 2022 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Review Board
 









 
 

  release-4.0.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
GitDiffParser (and subclasses) now extract UNIX file modes from the

mode lines and symlink targets from the diff data, setting them on the

ParsedDiffFile, eventually making its way into FileDiff.


In the future, we'll be able to show these mode changes in the diff

viewer, or replicate them when applying a diff (technically they already

are, but we'll have the metadata surrounding those changes).

 








  


 
 

  
Unit tests pass.

 







 









 





  








 




 







   

    
    
Diff Revision 1


This is not the most recent revision of the diff. The latest diff is revision 2. See what's changed.

    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Add extraction of UNIX file modes and symlink targets from Git diffs.
     
`GitDiffParser` (and subclasses) now extract UNIX file modes from the
mode lines and symlink targets from the diff data, setting them on the
`ParsedDiffFile`, eventually making its way into `FileDiff`.

In the future, we'll be able to show these mode changes in the diff
viewer, or replicate them when applying a diff (technically they already
are, but we'll have the metadata surrounding those changes).

    

   
  		
  91320feb7d2cb7e4cff84df3cf6754c2a92ab4db
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/diffviewer/tests/test_forms.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/git.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/tests/test_git.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...