Add extraction of UNIX file modes and symlink targets from Git diffs.

Review Request #12069 — Created Feb. 20, 2022 and submitted

Information
chipx86
Review Board
release-4.0.x
Reviewers
reviewboard 
GitDiffParser (and subclasses) now extract UNIX file modes from the

mode lines and symlink targets from the diff data, setting them on the

ParsedDiffFile, eventually making its way into FileDiff.


In the future, we'll be able to show these mode changes in the diff

viewer, or replicate them when applying a diff (technically they already

are, but we'll have the metadata surrounding those changes).
Unit tests pass.
Summary 
Add extraction of UNIX file modes and symlink targets from Git diffs.
Description From Last Updated

W605 invalid escape sequence '\w'

 reviewbotreviewbot

W605 invalid escape sequence '\.'

 reviewbotreviewbot

W605 invalid escape sequence '\.'

 reviewbotreviewbot

W605 invalid escape sequence '\w'

 reviewbotreviewbot

W605 invalid escape sequence '\d'

 reviewbotreviewbot

F841 local variable 'mode_re' is assigned to but never used

 reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

chipx86
david
david 
  1. Ship It!
  2. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




chipx86




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Pushed to release-4.0.x (a1cf845)





 


 










  

 









     

    

   

  

  

   
   Loading...