Summary

Add extraction of UNIX file modes and symlink targets from Git diffs.

Review Request #12069 — Created Feb. 20, 2022 and submitted Feb. 21, 2022, 7:10 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

GitDiffParser (and subclasses) now extract UNIX file modes from the
mode lines and symlink targets from the diff data, setting them on the
ParsedDiffFile, eventually making its way into FileDiff.

In the future, we'll be able to show these mode changes in the diff
viewer, or replicate them when applying a diff (technically they already
are, but we'll have the metadata surrounding those changes).

Testing Done

Unit tests pass.

Commits

Summary	ID
Add extraction of UNIX file modes and symlink targets from Git diffs. `GitDiffParser` (and subclasses) now extract UNIX file modes from the mode lines and symlink targets from the diff data, setting them on the `ParsedDiffFile`, eventually making its way into `FileDiff`. In the future, we'll be able to show these mode changes in the diff viewer, or replicate them when applying a diff (technically they already are, but we'll have the metadata surrounding those changes).	32286ba3d8fa82f215c99f5058049d5aedcc7d41

Summary

Add extraction of UNIX file modes and symlink targets from Git diffs.

`GitDiffParser` (and subclasses) now extract UNIX file modes from the mode lines and symlink targets from the diff data, setting them on the `ParsedDiffFile`, eventually making its way into `FileDiff`. In the future, we'll be able to show these mode changes in the diff viewer, or replicate them when applying a diff (technically they already are, but we'll have the metadata surrounding those changes).

32286ba3d8fa82f215c99f5058049d5aedcc7d41

Issues

Description	From	Last Updated
W605 invalid escape sequence '\w'	reviewbot	Feb. 20, 2022, 5:02 p.m.
W605 invalid escape sequence '\.'	reviewbot	Feb. 20, 2022, 5:02 p.m.
W605 invalid escape sequence '\.'	reviewbot	Feb. 20, 2022, 5:02 p.m.
W605 invalid escape sequence '\w'	reviewbot	Feb. 20, 2022, 5:02 p.m.
W605 invalid escape sequence '\d'	reviewbot	Feb. 20, 2022, 5:02 p.m.
F841 local variable 'mode_re' is assigned to but never used	reviewbot	Feb. 20, 2022, 5:03 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/scmtools/git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W605 invalid escape sequence '\w'
```
reviewboard/scmtools/git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W605 invalid escape sequence '\.'
```
reviewboard/scmtools/git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W605 invalid escape sequence '\.'
```
reviewboard/scmtools/git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W605 invalid escape sequence '\w'
```
reviewboard/scmtools/git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W605 invalid escape sequence '\d'
```
reviewboard/scmtools/git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F841 local variable 'mode_re' is assigned to but never used
```

Change Summary:


Marked regex strings with a r prefix to avoid errors.
Removed an unused variable.

Commits:

	Summary	ID
	Add extraction of UNIX file modes and symlink targets from Git diffs. `GitDiffParser` (and subclasses) now extract UNIX file modes from the mode lines and symlink targets from the diff data, setting them on the `ParsedDiffFile`, eventually making its way into `FileDiff`. In the future, we'll be able to show these mode changes in the diff viewer, or replicate them when applying a diff (technically they already are, but we'll have the metadata surrounding those changes).	91320feb7d2cb7e4cff84df3cf6754c2a92ab4db
	Add extraction of UNIX file modes and symlink targets from Git diffs. `GitDiffParser` (and subclasses) now extract UNIX file modes from the mode lines and symlink targets from the diff data, setting them on the `ParsedDiffFile`, eventually making its way into `FileDiff`. In the future, we'll be able to show these mode changes in the diff viewer, or replicate them when applying a diff (technically they already are, but we'll have the metadata surrounding those changes).	32286ba3d8fa82f215c99f5058049d5aedcc7d41

Diff:

Revision 2 (+336 -70)

Show changes

	reviewboard/diffviewer/tests/test_forms.py
	reviewboard/scmtools/git.py
	reviewboard/scmtools/tests/test_git.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.0.x (a1cf845)

reviewboard/scmtools/git.py (Diff revision 1)

reviewboard/scmtools/git.py (Diff revision 1)

reviewboard/scmtools/git.py (Diff revision 1)

reviewboard/scmtools/git.py (Diff revision 1)