• 
  
    
 
    
 
    

    



    
    
    
    
     
    




    
 
    

  
    



    
 

 

  

  

 

    


  
    





    
 
    



  

    
 
 
    
  
    Fix a bunch of errors in query count assertions.
    
 
    

    



 
    
 
    

  Review Request #12057
  —
  Created Feb. 12, 2022 and submitted 

 
    


    




    




    






 
    
  
    
   Information

  
    



    
 
 
    
  david
 
    

    





    
 
 
    
  Review Board
 
    

    





    
 
 
    
  release-5.0.x
 
    

    





    
 
 
    
  
 
    

    





    
 
 
    
  
 
    

    



 
    



 
    
  
    
   Reviewers

  
    



    
 
 
    
  reviewboard
 
    

    





    
 
 
    
  
 
    

    



 
    



    


    
 
    




  

    
 
 
    
  
    With the update to Django, we had a number of tests that were asserting
    
on specific query counts that needed to be updated. These fall into two
    
categories:
    

      

    1. Datagrid tests were experiencing increased query counts because
      
   middleware had added a couple simple queries.
      2. 

    2. Adding items to a many-to-many relation is now done in a single query
      
   instead of two, so several tests had reduced query counts.
      3. 

    
 
    

    





  

    
 
 
    
  
    Ran unit tests.
    
 
    

    




 
    

    





    
 
    




  
    
 
 
    
  


    
 
    
  
   
    

    Summary
    ID

   
    
      
  

   
    

    

     
    
      Fix a bunch of errors in query count assertions.
      
    With the update to Django, we had a number of tests that were asserting
on specific query counts that needed to be updated. These fall into two
categories:

1. Datagrid tests were experiencing increased query counts because
   middleware had added a couple simple queries.
2. Adding items to a many-to-many relation is now done in a single query
   instead of two, so several tests had reduced query counts.

Testing Done:
Ran unit tests.
    
     
    

        		
    7330206acb2fd07d29a9182638fe819500c0058e

   
    


      
 
    

    
    
 
    

    






 









 
    

    



  
    
 
    

    


    












    
 




 

    


 













    
 





 
    
  
    
   
    



chipx86




   
    
   
    





    
  
    
 
    


 
    
  
    

   
    
   
    
    
     
chipx86


    
    
   
    

  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      Ship It!
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      2. 















    2. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      3. 


    

  
    
 
    

    












    
 



 
    
  
    
   
    



david




   
    
   
    
  
    
 
    


 
    
  
    

   
    
   
    
    
     Review request changed
    
    
   
    

  
    
  
    
  
    




    

  
    
   
    
    Status:
   
    
   
    

    Completed

   
    
  
    



  
    
   
    
    Change Summary:
   
    
   
    
    
    Pushed to django-3.2 (ceab149)