Always pass exc_info as a boolean.
Review Request #12055 — Created Feb. 12, 2022 and submitted — Latest diff uploaded
The
exc_infoargument to logging methods is just checked for
truthiness, but it's more correct to pass it as a bool rather than
passing in 1. This change does that for all offending calls.
Ran unit tests.
Diff Revision 2 (Latest)
orig
1
2
Commits
Files
| reviewboard/accounts/managers.py |
|---|
| reviewboard/accounts/backends/ad.py |
|---|
| reviewboard/accounts/backends/ldap.py |
|---|
| reviewboard/accounts/backends/x509.py |
|---|
| reviewboard/accounts/forms/pages.py |
|---|
| reviewboard/admin/middleware.py |
|---|
| reviewboard/attachments/models.py |
|---|
| reviewboard/extensions/templatetags/rb_extensions.py |
|---|
| reviewboard/hostingsvcs/bugzilla.py |
|---|
| reviewboard/hostingsvcs/github.py |
|---|
| reviewboard/hostingsvcs/jira.py |
|---|
| reviewboard/reviews/views.py |
|---|
| reviewboard/reviews/models/file_attachment_comment.py |
|---|
| reviewboard/reviews/models/review_request.py |
|---|
| reviewboard/reviews/templatetags/reviewtags.py |
|---|
| reviewboard/scmtools/svn/__init__.py |
|---|
| reviewboard/scmtools/svn/pysvn.py |
|---|
| reviewboard/scmtools/svn/subvertpy.py |
|---|
| reviewboard/ssh/client.py |
|---|
| reviewboard/webapi/resources/base_original_file.py |
|---|
| reviewboard/webapi/resources/base_patched_file.py |
|---|
| reviewboard/webapi/resources/diff.py |
|---|
| reviewboard/webapi/resources/review_request.py |
|---|