Summary

Always pass exc_info as a boolean.

Review Request #12055 — Created Feb. 12, 2022 and submitted Feb. 17, 2022, 10:49 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The exc_info argument to logging methods is just checked for
truthiness, but it's more correct to pass it as a bool rather than
passing in 1. This change does that for all offending calls.

Testing Done

Ran unit tests.

Commits

Summary	ID
Always pass exc_info as a boolean. The `exc_info` argument to logging methods is just checked for truthiness, but it's more correct to pass it as a bool rather than passing in 1. This change does that for all offending calls. Testing Done: Ran unit tests.	8ce57d696d9d82aaa7f478b4cf3197a07cbd03a8

Issues

Description	From	Last Updated
F821 undefined name 'path'	reviewbot	Feb. 12, 2022, 11:36 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/scmtools/svn/subvertpy.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F821 undefined name 'path'
```

Commits:

	Summary	ID
	Always pass exc_info as a boolean. The `exc_info` argument to logging methods is just checked for truthiness, but it's more correct to pass it as a bool rather than passing in 1. This change does that for all offending calls. Testing Done: Ran unit tests.	af6fe15c1b4c663ba64d0c457c750d8fb4df1a40
	Always pass exc_info as a boolean. The `exc_info` argument to logging methods is just checked for truthiness, but it's more correct to pass it as a bool rather than passing in 1. This change does that for all offending calls. Testing Done: Ran unit tests.	8ce57d696d9d82aaa7f478b4cf3197a07cbd03a8

Diff:

Revision 2 (+96 -88)

Show changes

	reviewboard/accounts/managers.py
	reviewboard/accounts/backends/ad.py
	reviewboard/accounts/backends/ldap.py
	reviewboard/accounts/backends/x509.py
	reviewboard/accounts/forms/pages.py
	reviewboard/admin/middleware.py
	reviewboard/attachments/models.py
	reviewboard/extensions/templatetags/rb_extensions.py
	15 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to django-3.2 (2f43386)