Always pass exc_info as a boolean.

Review Request #12055 — Created Feb. 12, 2022 and submitted — Latest diff uploaded

Information

Review Board
release-5.0.x

Reviewers

The exc_info argument to logging methods is just checked for
truthiness, but it's more correct to pass it as a bool rather than
passing in 1. This change does that for all offending calls.

Ran unit tests.

Changes between revision 1 and 2

orig
1
2

Commits

Summary ID Author
Always pass exc_info as a boolean.
The `exc_info` argument to logging methods is just checked for truthiness, but it's more correct to pass it as a bool rather than passing in 1. This change does that for all offending calls. Testing Done: Ran unit tests.
af6fe15c1b4c663ba64d0c457c750d8fb4df1a40 David Trowbridge
Always pass exc_info as a boolean.
The `exc_info` argument to logging methods is just checked for truthiness, but it's more correct to pass it as a bool rather than passing in 1. This change does that for all offending calls. Testing Done: Ran unit tests.
8ce57d696d9d82aaa7f478b4cf3197a07cbd03a8 David Trowbridge
reviewboard/scmtools/svn/subvertpy.py
Loading...