Summary

Add serialization for Enum and CombinedExpression.

Review Request #12043 — Created Feb. 4, 2022 and submitted March 6, 2022, 5:35 p.m.

Information

Owner

chipx86

Repository

Django Evolution

Branch

release-2.x

Bugs

Depends On

Reviewers

Groups

django-evolution

People

Description

This enhances the serialization support to represent Enum values and
CombinedExpression instances.

Enums are stored as a dictionary with metadata needed to resolve the
enum.

CombinedExpression is used only in generated Python code. It's turned
into a <left> <op> <right> expression in code. Support is partially
implemented for versions prior to Django 2.0, but not tested. This
feature is really only used in a way that matters for evolutions in 2.0
or higher, which is important, because prior versions don't support
object deconstruction, meaning they can't be serialized without explicit
serializers written for them.

Testing Done

Tested with upcoming changes that use these types.

Commits

Summary	ID
Add serialization for Enum and CombinedExpression. This enhances the serialization support to represent `Enum` values and `CombinedExpression` instances. `Enum`s are stored as a dictionary with metadata needed to resolve the enum. `CombinedExpression` is used only in generated Python code. It's turned into a `<left> <op> <right>` expression in code. Support is partially implemented for versions prior to Django 2.0, but not tested. This feature is really only used in a way that matters for evolutions in 2.0 or higher, which is important, because prior versions don't support object deconstruction, meaning they can't be serialized without explicit serializers written for them.	c9cf310bf851ef420ba56270111cdc20ad84c005

Summary

Add serialization for Enum and CombinedExpression.

This enhances the serialization support to represent `Enum` values and `CombinedExpression` instances. `Enum`s are stored as a dictionary with metadata needed to resolve the enum. `CombinedExpression` is used only in generated Python code. It's turned into a `<left> <op> <right>` expression in code. Support is partially implemented for versions prior to Django 2.0, but not tested. This feature is really only used in a way that matters for evolutions in 2.0 or higher, which is important, because prior versions don't support object deconstruction, meaning they can't be serialized without explicit serializers written for them.

c9cf310bf851ef420ba56270111cdc20ad84c005

Issues

Description	From	Last Updated
F401 'django_evolution.serialization.Enum' imported but unused	reviewbot	Feb. 4, 2022, 8:23 p.m.
F811 redefinition of unused 'test_with_deferrable' from line 303	reviewbot	Feb. 4, 2022, 8:23 p.m.

flake8 failed.

JSHint passed.

flake8

django_evolution/tests/test_serialization.py (Diff revision 1)
Show all issues
```
F401 'django_evolution.serialization.Enum' imported but unused
```
django_evolution/tests/test_serialization.py (Diff revision 1)
Show all issues
```
F811 redefinition of unused 'test_with_deferrable' from line 303
```

Change Summary:


Removed unused imports.
Removed a duplicate test function.

Commits:

	Summary	ID
	Add serialization for Enum and CombinedExpression. This enhances the serialization support to represent `Enum` values and `CombinedExpression` instances. `Enum`s are stored as a dictionary with metadata needed to resolve the enum. `CombinedExpression` is used only in generated Python code. It's turned into a `<left> <op> <right>` expression in code. Support is partially implemented for versions prior to Django 2.0, but not tested. This feature is really only used in a way that matters for evolutions in 2.0 or higher, which is important, because prior versions don't support object deconstruction, meaning they can't be serialized without explicit serializers written for them.	a6ece4f5eae3a51034c0c91767fc5fb915b7468c
	Add serialization for Enum and CombinedExpression. This enhances the serialization support to represent `Enum` values and `CombinedExpression` instances. `Enum`s are stored as a dictionary with metadata needed to resolve the enum. `CombinedExpression` is used only in generated Python code. It's turned into a `<left> <op> <right>` expression in code. Support is partially implemented for versions prior to Django 2.0, but not tested. This feature is really only used in a way that matters for evolutions in 2.0 or higher, which is important, because prior versions don't support object deconstruction, meaning they can't be serialized without explicit serializers written for them.	c9cf310bf851ef420ba56270111cdc20ad84c005

Diff:

Revision 2 (+656 -12)

Show changes

	django_evolution/serialization.py
	django_evolution/tests/test_serialization.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.x (500928d)